Repository navigation
Conversation
Member
There was a problem hiding this comment.
@mhajas Thanks for the PR! It looks good. I have just two comments.
mhajas
force-pushed
the
9679-Hot-Rod-map-storage-Authorization-services-no-downtime-store
branch
from
February 10, 2022 17:04
47d1cb2 to
02e3be7
Compare
mhajas
force-pushed
the
9679-Hot-Rod-map-storage-Authorization-services-no-downtime-store
branch
from
May 4, 2022 13:35
02e3be7 to
0180daf
Compare
martin-kanis
reviewed
May 5, 2022
Member
There was a problem hiding this comment.
I think we might leverage more generic HotRodStringPair instead. WDYT?
Contributor
Author
|
This PR will need to wait for this: #11816 to be merged first as it enables hot-rod tests in GHA again. Also, there are some test failures in GHA in my fork, I will investigate these. |
mhajas
force-pushed
the
9679-Hot-Rod-map-storage-Authorization-services-no-downtime-store
branch
4 times, most recently
from
May 6, 2022 09:11
9aaf059 to
be10f71
Compare
martin-kanis
approved these changes
May 6, 2022
Member
There was a problem hiding this comment.
@mhajas Thanks! It looks good. Can you mark it as "ready for review" or it's still in progress?
mhajas
marked this pull request as ready for review
May 6, 2022 11:05
martin-kanis
approved these changes
May 6, 2022
8000
hmlnarik
approved these changes
May 6, 2022
Contributor
There was a problem hiding this comment.
Approving per @martin-kanis 's approval
mhajas
deleted the
9679-Hot-Rod-map-storage-Authorization-services-no-downtime-store
branch
July 7, 2022 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #9798 needs to be merged before this one.