Repository navigation
Conversation
|
@pedroigor Hi, could you have a look if this is something that would make sense, and if so give me a comment on that. I merged it against your new changes. |
There was a problem hiding this comment.
Thanks.
Could you please provide a test here https://github.com/keycloak/keycloak/blob/d27635fb1b2cf6c411902357cd6fbad7498d102b/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/AdminClientTest.java?
Perhaps you can look at the access token returned by the server and see if the claims/scope are there as expected.
|
@pedroigor Do you think the test is sufficient? |
|
@mteubner Thanks, it is. |
|
Sorry that I pulled you in on that Request, but I saw you changed something on the client as the last person. ;) What would be the next step to promote this feature? |
|
@mteubner I think I merged too fast ... I missed the issue and the commit properly updated referencing the issue :) |
|
The issue in the pipeline is not exclusive to this branch it also happends in most of the other pull-requests currently. So, I don't think it is due to the changes of this branch. What do you mean be properly update the referencing? Shall I do something here? |
|
Yes, it is not related. I meant I should have asked you to create an issue and update the commit message (and squash to a single one). But now is late :) Sorry. |
|
No worries. It is me that should apologize. Anyhow, I think it is a good feature. I also created Idea #10759, before, shall I clone an issue from that? |
|
@mteubner Please ... Then I'll update to include the project/milestone. |
|
I created an enhancement task #11032 |
|
Thanks |
Add scope parameter to admin-client TokenManager.
Closes #10759
Closes #11032