8000 Upgrading Hibernate in line with WildFly 26.0.1.Final to support building Keycloak with OpenJDK 17 by ahus1 · Pull Request #10781 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Upgrading Hibernate in line with WildFly 26.0.1.Final to support building Keycloak with OpenJDK 17 - #10781

Merged
hmlnarik merged 1 commit into
keycloak:mainfrom
ahus1:9993-upgrade-hibernate-for-jdk17
Mar 25, 2022
Merged

Upgrading Hibernate in line with WildFly 26.0.1.Final to support building Keycloak with OpenJDK 17#10781
hmlnarik merged 1 commit into
keycloak:mainfrom
ahus1:9993-upgrade-hibernate-for-jdk17

Conversation

@ahus1
@ahus1 ahus1 commented Mar 17, 2022
Copy link
Copy Markdown
Member

Closes #9993

@ahus1 ahus1 self-assigned this Mar 17, 2022
@ahus1 ahus1 added area/storage Storage layer — JPA entities, database schemas, Liquibase migrations, caching team/storage-sig labels Mar 17, 2022
@ahus1
ahus1 requested a review from sguilhen March 17, 2022 09:12
@ahus1
ahus1 commented Mar 22, 2022
Copy link
Copy Markdown
Member Author

I was waiting for this to run on the internal Jenkins pipeline to see that this change works on all databases.

@ahus1
ahus1 commented Mar 25, 2022
Copy link
Copy Markdown
Member Author

@sguilhen - I ran a build pipeline keycloak-build-pipeline/587 and test pipeline universal-test-pipeline-server/1347. The peid is cfe60c30.

The Oracle DB tests failed probably due to a DB not being available. Please have a look at the pipeline parameters and also the result - it's the first time I'm running this pipeline. Thanks!

@sguilhen
sguilhen commented Mar 25, 2022
Copy link
Copy Markdown
Contributor

Thanks @ahus1 . I'll take a look

@sguilhen
sguilhen commented Mar 25, 2022
Copy link
Copy Markdown
Contributor

Something funky happened in the pipeline, the migration tests were not executed and some of the db tests didn't run as well. I've triggered a rebuild to see how it goes.

@sguilhen
sguilhen commented Mar 25, 2022
Copy link
Copy Markdown
Contributor

Pipeline run: https://keycloak-jenkins.com/job/universal-test-pipeline-server/1351

sguilhen
sguilhen approved these changes Mar 25, 2022
View reviewed changes
@sguilhen sguilhen left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hibernate 5.3.24 is already productized internally and pipeline db_tests and db_migration_tests results are clean. Approving!

hmlnarik
hmlnarik approved these changes Mar 25, 2022
View reviewed changes
@hmlnarik hmlnarik left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per @sguilhen 's approval

@hmlnarik
hmlnarik merged commit 6a657e6 into keycloak:main Mar 25, 2022
@ahus1
ahus1 deleted the 9993-upgrade-hibernate-for-jdk17 branch March 28, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@sguilhen sguilhen sguilhen approved these changes
@hmlnarik hmlnarik hmlnarik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

area/storage Storage layer — JPA entities, database schemas, Liquibase migrations, caching

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Keycloak Model Map JPA module JDK 17 ready

3 participants

@ahus1 @sguilhen @hmlnarik
0