8000 Allow using an additional persistence unit and datasource by pedroigor · Pull Request #10581 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Allow using an additional persistence unit and datasource - #10581

Merged
abstractj merged 1 commit into
keycloak:mainfrom
pedroigor:issue-10579
Mar 8, 2022
Merged

Allow using an additional persistence unit and datasource#10581
abstractj merged 1 commit into
keycloak:mainfrom
pedroigor:issue-10579

Conversation

@pedroigor
@pedroigor pedroigor commented Mar 3, 2022 •
edited
Loading
Copy link
Copy Markdown
Contributor

Closes #10579

  • Support for multiple persistence units (other than Keycloak default)
  • For each user-defined PU, an additional NamedJpaConnectionFactory is installed to resolve JpaConnectionProvider instances from the KeycloakSession based on the name of the PU
  • Updated quickstart to run using the new distribution.

@pedroigor
pedroigor force-pushed the issue-10579 branch 2 times, most recently from 8e297ee to a831e85 Compare March 4, 2022 20:40
@pedroigor
pedroigor marked this pull request as ready for review March 5, 2022 00:59
@sebacla
sebacla commented Mar 7, 2022
Copy link
Copy Markdown

I think this PR solve the issue #10544

DGuhr
DGuhr approved these changes Mar 8, 2022
View reviewed changes
@DGuhr DGuhr left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you!

There are 2 unused imports, but not blocking for me right now, so approved. :)

@pedroigor pedroigor mentioned this pull request Mar 8, 2022
Closed
@ahus1
ahus1 self-requested a review March 8, 2022 14:14
ahus1
ahus1 approved these changes Mar 8, 2022
View reviewed changes
@ahus1 ahus1 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this together with the new quickstarts guide for a user provider and worked as expected for me.

@abstractj
abstractj merged commit c11a6e3 into keycloak:main Mar 8, 2022
@pedroigor
pedroigor deleted the issue-10579 branch March 8, 2022 15:21
@pedroigor pedroigor added this to the 18.0.0 milestone Mar 11, 2022
@dasniko
dasniko commented Mar 19, 2022
Copy link
Copy Markdown
Contributor

Unfortunately, it seems not to work completely, see #10547 (reply in thread)

@Nitue
Nitue commented Mar 31, 2022
Copy link
Copy Markdown

Does not seem to work when running in Docker container. Not sure about the solution but work around can be found here #10547 (reply in thread)

@pedroigor pedroigor self-assigned this Apr 12, 2022
@guilhem-lk guilhem-lk mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abstractj abstractj abstractj approved these changes
@ahus1 ahus1 ahus1 approved these changes
+2 more reviewers
@sebacla sebacla sebacla approved these changes
@DGuhr DGuhr DGuhr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@pedroigor pedroigor

Labels

None yet

Projects

Keycloak: Quarkus distribution
Status: Done

Milestone

18.0.0

Development

Successfully merging this pull request may close these issues.

Allow using an additional persistence unit and datasource

7 participants

@pedroigor @sebacla @dasniko @Nitue @abstractj @ahus1 @DGuhr
0