8000 Credential validation for user storage · Issue #9932 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Credential validation for user storage #9932

New issue
New issue
Closed
Closed
Credential validation for user storage#9932
Assignees
ahus1hmlnarik
Labels
area/storageStorage layer — JPA entities, database schemas, Liquibase migrations, cachingkind/featureCategorizes a PR related to a new feature

Description

@hmlnarik
hmlnarik
opened on Feb 2, 2022

Description

Design and develop a mechanism for credential validation on physical layer.

In the current store, credential validation is done in implementations of CredentialInputValidator interface in the logical layer. This has to be modified to support credential manipulation / validation on physical layer.

Activity

  1. hmlnarik
    changed the title [-]Creadential validation for user storage[/-] [+]Credential validation for user storage[/+] on Feb 2, 2022
  2. hmlnarik
    added
    area/storageStorage layer — JPA entities, database schemas, Liquibase migrations, caching
    kind/featureCategorizes a PR related to a new feature
    team/storage-sig
    on Feb 2, 2022
  3. hmlnarik
    self-assigned this
    on Feb 2, 2022

  4. hmlnarik commented on Feb 12, 2022

    @hmlnarik
    hmlnarik
    on Feb 12, 2022
    ContributorAuthor

    Idea: The validation, rather than on store provider level, could be done on single user level. That means that individual entities would be able to leverage credential validation mechanism available by that particular technology.

  5. ahus1
    self-assigned this
    on Mar 14, 2022

  6. ahus1 commented on Mar 14, 2022

    @ahus1
    ahus1
    on Mar 14, 2022
    Member

    I'd be happy to discuss what would be necessary here as it is one of the next things necessary for the LDAP implementation.

    I haven't worked with these APIs before, still I wonder if

    • an LdapMapUserCredentialEntity could contain "just" the DN plus plus some LDAP meta information, that is then copied to the CredentialModel; secretData would be empty
    • an LdapCredentialInputValidator that would use these to validate a CredentialInput of PasswordUserCredentialModel to run it agains the LDAP server

    Please let me know what you think.

  7. ahus1 commented on Mar 21, 2022

    @ahus1
    ahus1
    on Mar 21, 2022
    Member

    Started a discussion for this: #10833

  8. hmlnarik
    moved this from 📤 Todo to 👀 In Progress in Storageon May 5, 2022
  9. hmlnarik
    linked a pull request that will close this issueRun Infinispan using Testcontainers in base testsuite #13687on Aug 11, 2022
  10. hmlnarik
    removed a link to a pull requestRun Infinispan using Testcontainers in base testsuite #13687on Aug 11, 2022

  11. hmlnarik commented on Aug 11, 2022

    @hmlnarik
    hmlnarik
    on Aug 11, 2022
    ContributorAuthor

    Implemented in 19.0.0 (#11933) as UserModel.credentialManager()

  12. hmlnarik
    closed this as completedon Aug 11, 2022
  13. Repository owner moved this from 👀 In Progress to ✅ Done in Storageon Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area/storageStorage layer — JPA entities, database schemas, Liquibase migrations, cachingkind/featureCategorizes a PR related to a new feature

Type

No type

Fields

No fields configured for issues without a type.

Projects

  • Storage
    Status
    ✅ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions
0