Repository navigation
Adjust Minimal visualizer keystroke filtering options - #354
Conversation
| return [ud boolForKey:@"minimal.display.specialKeys"]; | ||
| } | ||
|
|
||
| return [ud boolForKey:@"minimal.display.allKeys"]; |
There was a problem hiding this comment.
These last two checks were returning YES for all keys because the modifier was pressed.
| : @"minimal.display.allKeys"; | ||
| if (![ud boolForKey:baseKeyPreference]) { | ||
| return NO; | ||
| } |
There was a problem hiding this comment.
Check whether to show keystroke.keyCode based on the appropriate preference.
|
Looking at code comments, I'm not sure if the intended behaviour was to show Likewise, it's strange to me that Modifiers (⌘ etc) are shown even when Command keys / Modified keys is unchecked. These settings are strangely worded, if the intention is to show key chords. |
|
@akitchen I'm going to propose this change, I know this isn't what you implemented here, but coming in with fresh eyes, and knowing the original intended use case... The preferences as you have them:
Andrew these settings are bonkers, do you disagree? They're all over the place. I propose this: Just a simple filter. Each checkbox does what it says - on every keypress, create the label, then filter based on these settings. Bam, simple, done. WDYT? |
c5867f5 to
c258044
Compare
c258044 to
61e4195
Compare
|
Yeah I agree it's confusing, how to structure the key filtering for this first release wasn't really clear and it was time to get something into people's hands. So I'm happy to iterate on this. Maybe the question to consider is whether we're just filtering different kinds of key presses, or working with the semantic meaning of different kinds of keystrokes (commands, modified keys, navigation keys, etc.). |
|
Cool cool, sorry if I sounded hot, I thought I was being cheeky – hopefully I was! 🤣 but re-reading I sound upset. Not so, and yeah now that it's released, it'll be easier to iterate on it. 👍 |
|
Thanks, yeah I like these options for filtering the keystrokes in this visualizer. I'll merge this and follow up with some nib cleanup and a small migration to remove the unused defaults. |
|
Heck yeah - thanks Andrew! |
I only use Minimal visualizer to show my modifiers, no navigation or printable characters.
I noticed that the visualizer was showing
⌃and⌘correctly, and hiding←andaBut if I press ⌥←, this would show both characters, instead of showing only
⌥