8000 TH-1315: testoppsett i keycloak med tester av CustomEndepunk by espgus · Pull Request #86 · kartverket/matrikkel-keycloak · GitHub
[go: up one dir, main page]

Skip to content

TH-1315: testoppsett i keycloak med tester av CustomEndepunk - #86

Merged
espgus merged 1 commit into
mainfrom
TH-1315
Apr 26, 2024
Merged

espgus merged 1 commit into
mainfrom
TH-1315

Conversation

@espgus
@espgus espgus commented Apr 11, 2024
Copy link
Copy Markdown
Contributor

TODO: fyllut mer

@espgus
espgus requested review from EbiJon, henriwi, lenped and lislei April 11, 2024 13:44
Comment thread extensions/build.gradle Resolved
Comment thread extensions/build.gradle Resolved
Comment thread extensions/build.gradle Resolved
@henriwi
henriwi commented Apr 12, 2024
Copy link
Copy Markdown
Contributor

Ser også at bygget feiler når testene kjører via docker build Så bør sjekke det lokalt og se om du klarer å se hvorfor ting feiler.

@espgus
espgus commented Apr 12, 2024
Copy link
Copy Markdown
Contributor Author

Ser også at bygget feiler når testene kjører via docker build Så bør sjekke det lokalt og se om du klarer å se hvorfor ting feiler.

Ja, det er da pga missmatch mellom keycloakversjoner i build.gradle og dockerfile

.assertThat().statusCode(
Matchers.anyOf(
Matchers.equalTo(401),
Matchers.equalTo(500))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denne bør vel alltid gi samme responskode? Så enten 401 eller 500 (vil tro 401 høres mest riktig ut).
Testen bør kun teste for en av statuskodene og feile i andre tilfeller.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Den gir 500 dessverre..

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, ok. Litt rart da. Klarer du å se noe i loggene på noe vis? Gir den også en 500 hvis du trigger endepunktet i kc-test/betatest?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ja, kan se ut som det har noe med hvordan exeptions blir håndtert. Skal titte litt mer på det...

Comment thread extensions/build.gradle Resolved
Comment thread extensions/build.gradle Resolved
@henriwi henriwi left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Litt småpirk og noen spørsmål om vi trenger alle testene.

@henriwi henriwi left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Et par småpirk, eller tenker jeg dette bare er å merge 👍 Bra jobba!

* Tester for kartverk-opprettede endepunkter i extention
@espgus
espgus merged commit 3e51059 into main Apr 26, 2024
@espgus
espgus deleted the TH-1315 branch April 26, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0