[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added generate tag in Cli test section #603

Closed
wants to merge 3 commits into from
Closed

Added generate tag in Cli test section #603

wants to merge 3 commits into from

Conversation

chetak123
Copy link
@chetak123 chetak123 commented Aug 24, 2022 •
edited
Loading

Related issue

fixes #553

Proposed Changes

I have added the generatedResource tag in test cli section along an example

Checklist

  • I have read the contributing guidelines.
  • I have inspected the website preview for accuracy.
  • I have signed off my issue.

@welcome
Copy link
welcome bot commented Aug 24, 2022

Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off.

@chipzoller
Copy link
Contributor

@chetak123 please complete the PR issue template and use closing keywords or manually link to the issue this will close.

@chetak123
Added generate tag in Cli test section
677f547 
Signed-off-by: Ayushman Mishra <ayushvidushi01@gmail.com>
shubham4443
shubham4443 suggested changes Aug 30, 2022
View reviewed changes
Copy link
@shubham4443 shubham4443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chetak123 thank you for opening PR for my issue!
Here are some of the changes I felt that needs to be done -

  1. This line needs to be updated. It mentions only validate and mutate policy is supported which is not the case.
  2. This line - mutate and generate rule can declare a pass

@chipzoller
Copy link
Contributor

@chetak123 please help close this PR out by addressing comments. It is needed in 1.8.0 docs.

chipzoller
chipzoller suggested changes Sep 11, 2022
View reviewed changes
content/en/docs/Kyverno CLI/_index.md Outdated Show resolved Hide resolved
@chetak123
changes done
7fee47f 
Signed-off-by: Ayushman Mishra <ayushvidushi01@gmail.com>
@chetak123
Copy link
Author

Hey @chipzoller I have made the required changes.

@chipzoller
Copy link
Contributor

@chetak123 would you mind please resolving conflicts here?

@chetak123
Merge branch 'main' into generate
67a9072 
Signed-off-by: Ayushman <53306550+chetak123@users.noreply.github.com>
@chipzoller chipzoller mentioned this pull request Oct 11, 2022
Merged
3 tasks
@chipzoller
Copy link
Contributor

@chetak123 I thank you for the PR and am incorporating your content (with attribution) in my PR #643. This was due to there being enough changes that it was easier to make them all myself.

@chipzoller chipzoller closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham4443 shubham4443 shubham4443 requested changes

@chipzoller chipzoller Awaiting requested review from chipzoller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.8.0] Document cli testing of policies with generate rule types
3 participants
@chetak123 @chipzoller @shubham4443