-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chainsaw tests for exceptions #9672
Merged
realshuting
merged 3 commits into
kyverno:main
from
MariamFahmy98:exceptions-report-test
Feb 7, 2024
Merged
feat: add chainsaw tests for exceptions #9672
realshuting
merged 3 commits into
kyverno:main
from
MariamFahmy98:exceptions-report-test
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariamFahmy98
requested review from
chipzoller,
eddycharly and
realshuting
as code owners
February 6, 2024 15:04
MariamFahmy98
force-pushed
the
exceptions-report-test
branch
from
February 6, 2024 15:39
5ad2438
to
1747452
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9672 +/- ##
=======================================
Coverage 33.28% 33.28%
=======================================
Files 344 344
Lines 23554 23554
=======================================
Hits 7839 7839
Misses 14872 14872
Partials 843 843 ☔ View full report in Codecov by Sentry. |
realshuting
previously approved these changes
Feb 7, 2024
/cherry-pick release-1.12 |
@MariamFahmy98 - new tests failed. |
MariamFahmy98
force-pushed
the
exceptions-report-test
branch
from
February 7, 2024 09:21
62fa14f
to
6b63c5e
Compare
realshuting
approved these changes
Feb 7, 2024
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
* feat: add chainsaw tests for exceptions Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> * fix test Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> --------- Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
realshuting
added
the
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
label
Feb 7, 2024
realshuting
pushed a commit
that referenced
this pull request
Feb 7, 2024
* feat: add chainsaw tests for exceptions * fix test --------- Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> Co-authored-by: Mariam Fahmy <mariam.fahmy@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
1Shubham7
pushed a commit
to 1Shubham7/kyverno
that referenced
this pull request
Feb 22, 2024
* feat: add chainsaw tests for exceptions Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> * fix test Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> --------- Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Shubham Singh <shubhammahar1306@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
cherry-pick-required
milestone 1.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR creates tests for re-evaluating exceptions and modify the generated reports accordingly.