[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: target scope validation for the generate rule #7800

Merged
merged 6 commits into from
Jul 10, 2023
Merged

fix: target scope validation for the generate rule #7800

merged 6 commits into from
Jul 10, 2023

Conversation

realshuting
Copy link
Member

Explanation

Fixes the target scope validation for the generate rule.

Related issue

Fixes #7750.

Milestone of this PR

bug

What type of PR is this

Proposed Changes

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.
    • I have added or changed the documentation myself in an existing PR and the link is:
    • I have raised an issue in kyverno/website to track the documentation update and the link is:

Further Comments

@realshuting
fix
9da08ac 
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting
Test: update kuttl tests
edc89bf 
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting
Copy link
Member Author

/cherry-pick release-1.10

@realshuting realshuting enabled auto-merge (squash) July 10, 2023 13:00
MariamFahmy98
MariamFahmy98 previously approved these changes Jul 10, 2023
View reviewed changes
@codecov
Copy link
codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #7800 (83e40c3) into main (4b5197d) will decrease coverage by 0.02%.
The diff coverage is 9.52%.

@@            Coverage Diff             @@
##             main    #7800      +/-   ##
==========================================
- Coverage   32.89%   32.87%   -0.02%     
==========================================
  Files         238      238              
  Lines       22503    22519      +16     
==========================================
+ Hits         7402     7403       +1     
- Misses      14344    14359      +15     
  Partials      757      757
Impacted Files Coverage Δ
pkg/background/generate/generate.go 0.00% <0.00%> (ø)
api/kyverno/v1/common_types.go 15.15% <22.22%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chipzoller
Copy link
Contributor

This needs a better title.

@chipzoller chipzoller mentioned this pull request Jul 10, 2023
Closed
2 tasks
@realshuting
Chore: update test file
d1cc42b 
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting realshuting changed the title Fix validation 7750 fix: target scope validation for the generate rule Jul 10, 2023
@realshuting
Copy link
Member Author

This needs a better title.

Updated!

@realshuting
Fix: ns scope
83e40c3 
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting
Fix: set resource apiversion
17b4eb1 
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting realshuting merged commit eb4b861 into kyverno:main Jul 10, 2023
@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error eb4b8614f0be4fcc0efdd15c3d7b8d499bdb4cb2 into temp-cherry-pick-3e2ab1-release-1.10

realshuting added a commit to realshuting/kyverno that referenced this pull request Jul 12, 2023
@realshuting
cherry-pick kyverno#7800
9e6fe70 
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting realshuting mentioned this pull request Jul 12, 2023
Merged
@realshuting realshuting added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Jul 12, 2023
realshuting added a commit that referenced this pull request Jul 12, 2023
@realshuting
cherry-pick #7800 (#7819)
532c1a0 
Signed-off-by: ShutingZhao <shuting@nirmata.com>
prady0t pushed a commit to prady0t/kyverno that referenced this pull request Jul 14, 2023
@realshuting @prady0t
Fix validation 7750 (kyverno#7800)
392658f 
* fix

Signed-off-by: ShutingZhao <shuting@nirmata.com>

* Test: update kuttl tests

Signed-off-by: ShutingZhao <shuting@nirmata.com>

---------

Signed-off-by: ShutingZhao <shuting@nirmata.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddycharly eddycharly eddycharly approved these changes

@chipzoller chipzoller Awaiting requested review from chipzoller

@MariamFahmy98 MariamFahmy98 Awaiting requested review from MariamFahmy98 MariamFahmy98 is a code owner

Assignees
No one assigned
Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required milestone 1.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Namespace required to generate a clusterpolicy
4 participants
@realshuting @chipzoller @eddycharly @MariamFahmy98