-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support multiple helm values #6810
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #6810 +/- ##
=======================================
Coverage ? 34.39%
=======================================
Files ? 216
Lines ? 21227
Branches ? 0
=======================================
Hits ? 7301
Misses ? 13225
Partials ? 701 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chipzoller
approved these changes
Apr 6, 2023
/cherry-pick release-1.10 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
added a commit
that referenced
this pull request
Apr 6, 2023
eddycharly
added
the
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
label
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
cherry-pick-required
milestone 1.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds support multiple helm values through makefile targets.