[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: introduce pss validation handler #6724

Merged
merged 11 commits into from
Mar 30, 2023
Merged

refactor: introduce pss validation handler #6724

merged 11 commits into from
Mar 30, 2023

Conversation

eddycharly
Copy link
Member

Explanation

This PR introduce pss validation handler.
Instead of embedding it in the resource validation handler.

@eddycharly
refactor: remove rules pointer
be38b30 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
refactor: introduce pss validation handler
fa58a76 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly added this to the Kyverno Release 1.10.0 milestone Mar 29, 2023
@eddycharly
Merge branch 'main' into validate-pss-handler
fd58518
@eddycharly
handler
8077c68 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
Merge branch 'main' into validate-pss-handler
8f68485
@eddycharly
merge main
fbe1c0f 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly marked this pull request as ready for review March 29, 2023 18:30
@eddycharly eddycharly enabled auto-merge (squash) March 29, 2023 18:51
@codecov
Copy link
codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Merging #6724 (38c95a8) into main (5155412) will increase coverage by 0.02%.
The diff coverage is 8.94%.

@@            Coverage Diff             @@
##             main    #6724      +/-   ##
==========================================
+ Coverage   34.37%   34.39%   +0.02%     
==========================================
  Files         212      213       +1     
  Lines       21048    21042       -6     
==========================================
+ Hits         7235     7238       +3     
+ Misses      13113    13102      -11     
- Partials      700      702       +2
Impacted Files Coverage Δ
api/kyverno/v1/rule_types.go 57.39% <0.00%> (+0.98%) ⬆️
api/kyverno/v1/spec_types.go 17.05% <0.00%> (ø)
api/kyverno/v2beta1/rule_types.go 64.63% <0.00%> (+3.00%) ⬆️
api/kyverno/v2beta1/spec_types.go 19.23% <0.00%> (ø)
pkg/controllers/webhook/controller.go 0.00% <0.00%> (ø)
pkg/engine/handlers/validation/validate_pss.go 0.00% <0.00%> (ø)
...kg/engine/handlers/validation/validate_resource.go 0.00% <ø> (ø)
pkg/engine/validation.go 74.46% <46.15%> (-4.11%) ⬇️
cmd/cli/kubectl-kyverno/utils/common/common.go 17.82% <50.00%> (ø)
pkg/engine/engine.go 70.94% <100.00%> (+0.25%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@realshuting
Copy link
Member

@YTGhost - can you help co-review the PR?

realshuting
realshuting approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member
@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@YTGhost
Copy link
Member
YTGhost commented Mar 30, 2023

@YTGhost - can you help co-review the PR?

LGTM

@eddycharly eddycharly merged commit d0841e4 into kyverno:main Mar 30, 2023
vishal-chdhry pushed a commit to vishal-chdhry/kyverno that referenced this pull request Mar 30, 2023
@eddycharly @vishal-chdhry
refactor: introduce pss validation handler (kyverno#6724)
4135b85 
* refactor: remove rules pointer

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* refactor: introduce pss validation handler

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* handler

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

---------

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realshuting realshuting realshuting approved these changes

@MarcelMue MarcelMue Awaiting requested review from MarcelMue

Assignees
No one assigned
Labels
milestone 1.10.0
Projects
None yet
Milestone
Kyverno Release 1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eddycharly @realshuting @YTGhost