[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve policycache package #3495

Merged
merged 5 commits into from
Mar 29, 2022
Merged

refactor: improve policycache package #3495

merged 5 commits into from
Mar 29, 2022

Conversation

eddycharly
Copy link
Member

This PR improves the policycache package:

  • make methods private when possible
  • uses composition over embedding
  • split policy_cache.go and policy_map.go files

@eddycharly eddycharly added this to the Kyverno Release 1.7.0 milestone Mar 29, 2022
@eddycharly
refactor: improve policycache package
1cef3c9 
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
prateekpandey14
prateekpandey14 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor
@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link
codecov-commenter commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #3495 (2e47083) into main (80d1ccb) will decrease coverage by 0.00%.
The diff coverage is 65.95%.

@@            Coverage Diff             @@
##             main    #3495      +/-   ##
==========================================
- Coverage   25.93%   25.93%   -0.01%     
==========================================
  Files         139      140       +1     
  Lines       20044    20043       -1     
==========================================
- Hits         5199     5198       -1     
  Misses      14212    14212              
  Partials      633      633
Impacted Files Coverage Δ
pkg/policycache/informer.go 4.47% <0.00%> (ø)
pkg/policycache/policy_cache.go 52.00% <52.00%> (ø)
pkg/policycache/policy_map.go 94.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d1ccb...2e47083. Read the comment docs.

@eddycharly
Copy link
Member Author

@prateekpandey14 can we merge this ?

@prateekpandey14 prateekpandey14 enabled auto-merge (squash) March 29, 2022 17:19
@prateekpandey14 prateekpandey14 merged commit 1fce53f into kyverno:main Mar 29, 2022
@prateekpandey14 prateekpandey14 self-assigned this Mar 29, 2022
@dkulchinsky dkulchinsky mentioned this pull request Apr 29, 2022
Merged
9 tasks
@realshuting realshuting added the release notes This label is added to the PR without a corresponding issue. It is used to create release notes. label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekpandey14 prateekpandey14 prateekpandey14 approved these changes

@sambhav sambhav Awaiting requested review from sambhav

@realshuting realshuting Awaiting requested review from realshuting

Assignees

@prateekpandey14 prateekpandey14

Labels
release notes This label is added to the PR without a corresponding issue. It is used to create release notes.
Projects
None yet
Milestone
Kyverno Release 1.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@eddycharly @codecov-commenter @prateekpandey14 @realshuting