feat: add reporting to mutate and generate rules #11265

vishal-chdhry · 2024-09-30T06:59:26Z

Explanation

Related issue

Related to #3837

Milestone of this PR

Documentation (required for features)

My PR contains new or altered behavior to Kyverno.

I have sent the draft PR to add or update the documentation and the link is:

What type of PR is this

Proposed Changes

Proof Manifests

Checklist

I have read the contributing guidelines.
I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
This is a bug fix and I have added unit tests that prove my fix is effective.
This is a feature and I have added CLI tests that are applicable.
My PR needs to be cherry picked to a specific release branch which is .
My PR contains new or altered behavior to Kyverno and
- CLI support should be added and my PR doesn't contain that functionality.

Further Comments

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

codecov · 2024-09-30T07:13:31Z

Codecov Report

Attention: Patch coverage is 12.72727% with 240 lines in your changes missing coverage. Please review.

Project coverage is 12.23%. Comparing base (12edb6d) to head (fd4af05).
Report is 80 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/utils/report/results.go	0.00%	43 Missing ⚠️
pkg/background/mutate/mutate.go	0.00%	33 Missing ⚠️
pkg/background/generate/controller.go	0.00%	31 Missing ⚠️
pkg/policy/generate/validate.go	3.33%	28 Missing and 1 partial ⚠️
pkg/policy/mutate/validate.go	48.57%	12 Missing and 6 partials ⚠️
cmd/background-controller/main.go	0.00%	14 Missing ⚠️
pkg/background/update_request_controller.go	0.00%	14 Missing ⚠️
pkg/controllers/report/aggregate/controller.go	0.00%	13 Missing ⚠️
pkg/webhooks/resource/mutation/mutation.go	40.90%	12 Missing and 1 partial ⚠️
pkg/breaker/resource_counter.go	0.00%	12 Missing ⚠️
... and 3 more

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #11265    +/-   ##
========================================
  Coverage   12.22%   12.23%            
========================================
  Files         946      945     -1     
  Lines       87341    87699   +358     
========================================
+ Hits        10676    10728    +52     
- Misses      75355    75647   +292     
- Partials     1310     1324    +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

realshuting · 2024-09-30T08:10:23Z

@vishal-chdhry - can you link to the related issue?

realshuting

@eddycharly - can you please help review the report related changed?

We also need a doc issue for this change.

pkg/controllers/report/aggregate/controller.go

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

pkg/policy/mutate/validate.go

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

vishal-chdhry · 2024-10-03T09:31:46Z

/cherry-pick release-1.13

* feat: add reports to standard mutatation Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * feat: add warnings for permissions Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: remove unnecessary fields Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * feat: add reporting to generate and mutate existing Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * feat: add reporting to generate and mutate existing Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: codegen and add generate tests Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: linter Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: e2e matrix Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: cleanup Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> --------- Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

…#11306) * fix(refactor): move breaker resource counter to pkg (#11271) Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * feat: add reporting to mutate and generate rules (#11265) * feat: add reports to standard mutatation Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * feat: add warnings for permissions Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: remove unnecessary fields Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * feat: add reporting to generate and mutate existing Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * feat: add reporting to generate and mutate existing Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: codegen and add generate tests Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: linter Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: e2e matrix Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: cleanup Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> --------- Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> --------- Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* feat: add reports to standard mutatation Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * feat: add warnings for permissions Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: remove unnecessary fields Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * feat: add reporting to generate and mutate existing Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * feat: add reporting to generate and mutate existing Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: codegen and add generate tests Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: linter Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: e2e matrix Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: cleanup Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> --------- Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

feat: add reports to standard mutatation

a48e6b8

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

vishal-chdhry requested review from eddycharly, realshuting and MariamFahmy98 as code owners September 30, 2024 06:59

dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 30, 2024

realshuting added cherry-pick-required milestone 1.13.0 labels Sep 30, 2024

realshuting reviewed Sep 30, 2024

View reviewed changes

pkg/controllers/report/aggregate/controller.go Show resolved Hide resolved

vishal-chdhry added 2 commits September 30, 2024 14:14

Merge branch 'main' into mutation-reports

3f379ae

feat: add warnings for permissions

064a6bb

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

vishal-chdhry requested a review from realshuting September 30, 2024 09:22

realshuting reviewed Sep 30, 2024

View reviewed changes

pkg/policy/mutate/validate.go Outdated Show resolved Hide resolved

fix: remove unnecessary fields

eff7b65

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

vishal-chdhry requested a review from realshuting September 30, 2024 10:10

vishal-chdhry added 4 commits September 30, 2024 19:13

Merge branch 'main' into mutation-reports

f272031

Merge branch 'main' into mutation-reports

2388a93

feat: add reporting to generate and mutate existing

ec0cc30

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

feat: add reporting to generate and mutate existing

7facde0

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 30, 2024

vishal-chdhry requested a review from JimBugwadia September 30, 2024 16:54

vishal-chdhry added 2 commits October 1, 2024 11:19

fix: codegen and add generate tests

c528de8

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

fix: linter

42fdcdc

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

vishal-chdhry changed the title ~~feat: add reports to standard mutatation~~ feat: add reporting to mutate and generate rules Oct 1, 2024

vishal-chdhry added 2 commits October 1, 2024 12:46

fix: e2e matrix

fcb4cb4

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

fix: cleanup

72d0634

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

MariamFahmy98 self-assigned this Oct 1, 2024

eddycharly approved these changes Oct 2, 2024

View reviewed changes

Merge branch 'main' into mutation-reports

fd4af05

eddycharly enabled auto-merge (squash) October 2, 2024 11:42

eddycharly merged commit fe49e97 into kyverno:main Oct 2, 2024
547 of 553 checks passed

vishal-chdhry mentioned this pull request Oct 3, 2024

feat: add reporting to mutate and generate rules (#11265) #11305

Closed

8 tasks

eddycharly added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Oct 3, 2024

eddycharly mentioned this pull request Oct 3, 2024

feat: add reporting to mutate and generate rules (cherry-pick #11265) #11306

Merged

vishal-chdhry mentioned this pull request Oct 15, 2024

[Feature] Audit mode & reporting for mutate and generate rules #3837

Closed

2 tasks

marcm-ml mentioned this pull request Nov 8, 2024

[Bug] Multiple Mutating or Generating Policies targeting the same resource errors in the background controller when creating a clusterEphemeralReport #11561

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add reporting to mutate and generate rules #11265

feat: add reporting to mutate and generate rules #11265

feat: add reporting to mutate and generate rules #11265

feat: add reporting to mutate and generate rules #11265

Conversation

Explanation

Related issue

Milestone of this PR

Documentation (required for features)

What type of PR is this

Proposed Changes

Proof Manifests

Checklist

Further Comments

Codecov Report

Choose a reason for hiding this comment