[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mutate): minimize unmarshals #10702

Merged
merged 4 commits into from
Aug 9, 2024
Merged

feat(mutate): minimize unmarshals #10702

merged 4 commits into from
Aug 9, 2024

Conversation

KhaledEmaraDev
Copy link
Contributor

Explanation

Minimize the number of times we have to unmarshal within mutate policies.

Related issue

Milestone of this PR

Documentation (required for features)

My PR contains new or altered behavior to Kyverno.

What type of PR is this

Proposed Changes

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.

Further Comments

@KhaledEmaraDev KhaledEmaraDev added this to the Kyverno Release 1.13.0 milestone Jul 23, 2024
@codecov Codecov
Copy link
codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.

Project coverage is 11.66%. Comparing base (6e73e85) to head (5062610).

Files Patch % Lines
api/kyverno/v1/common_types.go 0.00% 4 Missing ⚠️
pkg/engine/mutate/mutation.go 70.00% 2 Missing and 1 partial ⚠️
api/kyverno/v1/zz_generated.deepcopy.go 0.00% 1 Missing ⚠️
.../applyconfigurations/kyverno/v1/foreachmutation.go 0.00% 1 Missing ⚠️
pkg/engine/handlers/mutation/common.go 0.00% 1 Missing ⚠️
pkg/policy/mutate/validate.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10702      +/-   ##
==========================================
+ Coverage   11.64%   11.66%   +0.01%     
==========================================
  Files         933      933              
  Lines       85285    85281       -4     
==========================================
+ Hits         9933     9945      +12     
+ Misses      74223    74203      -20     
- Partials     1129     1133       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@realshuting realshuting self-assigned this Jul 25, 2024
@KhaledEmaraDev
feat(mutate): minimize unmarshals
0786af7 
Signed-off-by: Khaled Emara <khaled.emara@nirmata.com>
@KhaledEmaraDev
test(mutate): test type assertion
901ef40 
Signed-off-by: Khaled Emara <khaled.emara@nirmata.com>
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 5, 2024
@KhaledEmaraDev
chore(codegen): remove unused import
c60b20e 
Signed-off-by: Khaled Emara <khaled.emara@nirmata.com>
@realshuting realshuting enabled auto-merge (squash) August 9, 2024 10:21
@realshuting realshuting merged commit 65a43d2 into kyverno:main Aug 9, 2024
259 of 260 checks passed
aerosouund pushed a commit to aerosouund/kyverno that referenced this pull request Aug 28, 2024
@KhaledEmaraDev @aerosouund
feat(mutate): minimize unmarshals (kyverno#10702)
01990b1 
* feat(mutate): minimize unmarshals

Signed-off-by: Khaled Emara <khaled.emara@nirmata.com>

* test(mutate): test type assertion

Signed-off-by: Khaled Emara <khaled.emara@nirmata.com>

* chore(codegen): remove unused import

Signed-off-by: Khaled Emara <khaled.emara@nirmata.com>

---------

Signed-off-by: Khaled Emara <khaled.emara@nirmata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realshuting realshuting realshuting approved these changes

@MarcelMue MarcelMue Awaiting requested review from MarcelMue

@MariamFahmy98 MariamFahmy98 Awaiting requested review from MariamFahmy98 MariamFahmy98 is a code owner

@chipzoller chipzoller Awaiting requested review from chipzoller

@eddycharly eddycharly Awaiting requested review from eddycharly eddycharly is a code owner

Assignees

@realshuting realshuting

Labels
milestone 1.13.0 performance size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Pull Requests Tracker
Status: Done
Milestone
Kyverno Release 1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@KhaledEmaraDev @realshuting