8000 Rename MINIKUBE_IN_COLOR to MINIKUBE_IN_STYLE by tstromberg · Pull Request #3976 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Rename MINIKUBE_IN_COLOR to M 8000 INIKUBE_IN_STYLE - #3976

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
tstromberg:in_style
Mar 26, 2019
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
tstromberg:in_style

Conversation

@tstromberg
Copy link
Copy Markdown
Contributor

This name is more meaningful, particularly as:

  • minikube currently has no color outside of colored emoji icons
  • not all terminal environments render the emoji icons in color

Since this is a minor breaking change, I figured we should do it before 1.0.

@tstromberg
tstromberg requested a review from afbjorklund March 26, 2019 13:58
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2019
@afbjorklund
Copy link
Copy Markdown
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg
tstromberg merged commit 6469490 into kubernetes:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0