8000 Install crictl from binary instead of from source by afbjorklund · Pull Request #3160 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Install crictl from binary instead of from source - #3160

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
afbjorklund:crictl-bin
Oct 1, 2018
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
afbjorklund:crictl-bin

Conversation

@afbjorklund
Copy link
Copy Markdown
Collaborator

Since we already install docker and cni from binary

Since we already install docker and cni from binary
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 24, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aaron-prindle

If they are not already assigned, you can assign the PR to them by writing /assign @aaron-prindle in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2018
@afbjorklund
Copy link
Copy Markdown
Collaborator Author

Tested OK with Kubernetes v1.10.0 and KVM2.

$ ./out/minikube start --iso-url=file://$PWD/out/minikube.iso \
                       --network-plugin=cni --container-runtime=cri-o

@tstromberg
tstromberg merged commit 96d0f14 into kubernetes:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0