8000 Allow to override build date with SOURCE_DATE_EPOCH by bmwiedemann · Pull Request #3009 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Allow to override build date with SOURCE_DATE_EPOCH - #3009

Merged
dlorenc merged 1 commit into
kubernetes:masterfrom
bmwiedemann:date
Jul 24, 2018
Merged

dlorenc merged 1 commit into
kubernetes:masterfrom
bmwiedemann:date

Conversation

@bmwiedemann
Copy link
Copy Markdown
Contributor

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Fixes #3005

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Fixes #3005
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 23, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bmwiedemann
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@dlorenc
dlorenc commented Jul 23, 2018
Copy link
Copy Markdown
Contributor

@minikube-bot test this please

@dlorenc
dlorenc merged commit 3c0dd23 into kubernetes:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0