Repository navigation
Add GPU support to minikube. - #2936
#2936Conversation
|
/assign @vishh |
|
Can one of the admins verify this patch? |
b65beec to
3dc19ac
Compare
|
This PR overall lgtm. I'd recommend having some of the users wanting this feature in #2115 to try this out as well. |
|
What would be the testing and maintenance story for this feature? If we need community help with maintenance, should we mark it as alpha/experimental until we can demonstrate sustained usage and maintenance? |
3dc19ac to
74e1908
Compare
94cfb5e to
741dc5f
Compare
741dc5f to
a79cf6c
Compare
|
/assign @dlorenc @r2d4 @aaron-prindle |
Commented on that issue.
The doc and help text say experimental. I would love to e2e test this but since GCE's nested virtualization doesn't have a virtual IOMMU, so we can't test this on GCE. If people have other ideas, I am all ears. |
a79cf6c to
c660256
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mindprince Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks! The PR looks good to me. I'd like to think about the testing for another day or so and see if we can come up with something. |
c660256 to
f4bd357
Compare
|
Ping. |
|
@minikube-bot OK to test |
Fixes #2115.
Testing this PR locally:
See the instructions added to docs/gpu.md in this PR. Even if you don't satisfy the prerequisites mentioned there, it would be useful to run these and check if the error messages returned are useful.