E24E Add GPU support to minikube. by rohitagarwal003 · Pull Request #2936 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add GPU support to minikube. - #2936

#2936
Merged
dlorenc merged 3 commits into
kubernetes:masterfrom
rohitagarwal003:gpu-support
Jul 9, 2018
Merged

dlorenc merged 3 commits into
kubernetes:masterfrom
rohitagarwal003:gpu-support

Conversation

@rohitagarwal003
@rohitagarwal003 rohitagarwal003 commented Jun 26, 2018 •
Copy link
Copy Markdown
Member

Fixes #2115.

Testing this PR locally:

See the instructions added to docs/gpu.md in this PR. Even if you don't satisfy the prerequisites mentioned there, it would be useful to run these and check if the error messages returned are useful.

# From your minikube checkout
git fetch origin pull/2936/head:gpu-support
git checkout gpu-support

# Build the docker machine plugin
make out/docker-machine-driver-kvm2
cp out/docker-machine-driver-kvm2 /usr/local/bin/docker-machine-driver-kvm2

# Build minikube
make out/minikube

# Run minikube with GPUs
out/minikube start --vm-driver kvm2 --gpu --logtostderr

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 26, 2018
@rohitagarwal003
8000 rohitagarwal003 commented Jun 26, 2018
Copy link
Copy Markdown
Member Author

/assign @vishh

@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@rohitagarwal003
rohitagarwal003 force-pushed the gpu-support branch 2 times, most recently from b65beec to 3dc19ac Compare June 26, 2018 17:20
@vishh
vishh commented Jun 27, 2018
Copy link
Copy Markdown
Contributor

This PR overall lgtm. I'd recommend having some of the users wanting this feature in #2115 to try this out as well.

@vishh
vishh commented Jun 27, 2018
Copy link
Copy Markdown
Contributor

What would be the testing and maintenance story for this feature? If we need community help with maintenance, should we mark it as alpha/experimental until we can demonstrate sustained usage and maintenance?

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2018
@rohitagarwal003
Copy link
Copy Markdown
Member Author

/assign @dlorenc @r2d4 @aaron-prindle

@rohitagarwal003
Copy link
Copy Markdown
Member Author

This PR overall lgtm. I'd recommend having some of the users wanting this feature in #2115 to try this out as well.

Commented on that issue.

What would be the testing and maintenance story for this feature? If we need community help with maintenance, should we mark it as alpha/experimental until we can demonstrate sustained usage and maintenance?

The doc and help text say experimental. I would love to e2e test this but since GCE's nested virtualization doesn't have a virtual IOMMU, so we can't test this on GCE. If people have other ideas, I am all ears.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mindprince
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aaron-prindle

Assign the PR to them by writing /assign @aaron-prindle in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dlorenc
dlorenc commented Jun 27, 2018
Copy link
Copy Markdown
Contributor

Thanks! The PR looks good to me. I'd like to think about the testing for another day or so and see if we can come up with something.

@rohitagarwal003
Copy link
Copy Markdown
Member Author

Ping.

@dlorenc
dlorenc commented Jul 4, 2018
Copy link
Copy Markdown
Contributor

@minikube-bot OK to test

@dlorenc
dlorenc merged commit db90809 into kubernetes:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

0