8000 Rm localkube by aaron-prindle · Pull Request #2911 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Rm localkube - #2911

Merged
dlorenc merged 12 commits into
kubernetes:masterfrom
aaron-prindle:rm-localkube
Jul 24, 2018
Merged

dlorenc merged 12 commits into
kubernetes:masterfrom
aaron-prindle:rm-localkube

Conversation

@aaron-prindle
Copy link
Copy Markdown
Contributor

branch based off of: #2870

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 18, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaron-prindle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2018
@dlorenc
dlorenc commented Jun 19, 2018
Copy link
Copy Markdown
Contributor

I think you might have to rebase, some of the tests here are still trying to run with bootstrapper=localkube

@dlorenc
dlorenc commented Jun 20, 2018
Copy link
Copy Markdown
Contributor

Let's hold off on merging this for a few days though, we might need to get a 0.28.1 point release out.

@dlorenc
dlorenc commented Jul 17, 2018
Copy link
Copy Markdown
Contributor

@aaron-prindle want to rebase and get this in?

@aaron-prindle
Copy link
Copy Markdown
Contributor Author

done

@dlorenc
dlorenc commented Jul 24, 2018
Copy link
Copy Markdown
Contributor

OK, I think this is ready to go.

@dlorenc
dlorenc merged commit 703f76d into kubernetes:master Jul 24, 2018
@dlorenc dlorenc mentioned this pull request Jul 30, 2018
4 of 5 tasks
@luxas
luxas commented Jul 30, 2018
Copy link
Copy Markdown
Member

Gotta love PRs that remove 2M LoC 😉

emmanuelCarre added a commit to emmanuelCarre/website that referenced this pull request Oct 1, 2018
Since PR kubernetes/minikube#2911, get-k8s-versions option had been
removed. Reference this option in documentation is not needed any more.
emmanuelCarre added a commit to emmanuelCarre/website that referenced this pull request Oct 1, 2018
Since PR kubernetes/minikube#2911, get-k8s-versions option had been
removed. Reference this option in documentation is not needed any more.
emmanuelCarre added a commit to emmanuelCarre/website that referenced this pull request Oct 1, 2018
Since PR kubernetes/minikube#2911, get-k8s-versions option has been
removed. Reference this option in documentation is not needed any more.
emmanuelCarre added a commit to emmanuelCarre/website that referenced this pull request Oct 7, 2018
Since PR kubernetes/minikube#2911, get-k8s-versions option has been
removed. Reference this option in documentation is not needed any more.
emmanuelCarre added a commit to emmanuelCarre/website that referenced this pull request Oct 7, 2018
Since PR kubernetes/minikube#2911, get-k8s-versions option has been
removed. Reference this option in documentation is not needed any more.
emmanuelCarre added a commit to emmanuelCarre/website that referenced this pull request Oct 7, 2018
Since PR kubernetes/minikube#2911, get-k8s-versions option has been
removed. Reference this option in documentation is not needed any more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0