8000 Add metrics-server as an addon by dvdmuckle · Pull Request #2566 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add metrics-server as an addon - #2566

Merged
r2d4 merged 1 commit into
kubernetes:masterfrom
dvdmuckle:master
Feb 22, 2018
Merged

r2d4 merged 1 commit into
kubernetes:masterfrom
dvdmuckle:master

Conversation

@dvdmuckle
Copy link
Copy Markdown
Contributor

Since K8s 1.9, metrics-server is by default used for getting metrics for HPAs, replacing the same function originally supplied by Heapster. While there is a flag to change this behavior and use Heapster for HPAs, it may be simpler to just add metrics-server as an addon.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dvdmuckle
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

Assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 22, 2018
@dvdmuckle
Copy link
Copy Markdown
Contributor Author

/assign @dlorenc

@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@dlorenc
dlorenc commented Feb 22, 2018
Copy link
Copy Markdown
Contributor

@minikube-bot ok to test

@r2d4
r2d4 merged commit 6e49d6a into kubernetes:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0