Repository navigation
Change kubernetes-dashboard from RC to deployment - #2409
#2409Merged
Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
Contributor
|
@minikube-bot ok to test |
Contributor
|
@minikube-bot retest this please |
Contributor
Author
|
Hi, @r2d4 could you help me to retest this? I also tried to manually run Linux-none(kubeadm bootstrapper) testing on Ubuntu 16.04, but the test can be performed successfully. |
Contributor
|
I think the test issues are with the machines themselves, I'm looking into it now that I'm back from the holidays. This LGTM though |
r2d4
approved these changes
Jan 10, 2018
jgoclawski
added a commit
to socialwifi/kubeyard
that referenced
this pull request
Dec 16, 2018
dashboard-rc.yaml no longer exists. kubernetes/minikube#2409
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit changed kubernetes-dashboard from RC to deployment, the feature request from #2389. This PR has been tested on v1.9.0(b109185), more command output detail as below:
Dashboard's preview:

Integration testing result: