8000 VirtualBox driver uses virtio network driver by ijl · Pull Request #2211 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

VirtualBox driver uses virtio network driver - #2211

Merged
dlorenc merged 1 commit into
kubernetes:masterfrom
ijl:vbox-virtio
Nov 27, 2017
Merged

dlorenc merged 1 commit into
kubernetes:masterfrom
ijl:vbox-virtio

Conversation

@ijl
@ijl ijl commented Nov 22, 2017
Copy link
Copy Markdown
Contributor

Kernel has CONFIG_VIRTIO_NET=y.

Read more at https://www.virtualbox.org/manual/ch06.html

Closes #2196.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2017
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@dlorenc
dlorenc commented Nov 22, 2017
Copy link
Copy Markdown
Contributor

Any chance you can sign the CLA?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 22, 2017
@ijl
ijl commented Nov 22, 2017
Copy link
Copy Markdown
Contributor Author

@dlorenc yes, CLA is green now.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2211 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2211      +/-   ##
==========================================
+ Coverage   27.73%   27.76%   +0.02%     
==========================================
  Files          82       82              
  Lines        5538     5540       +2     
==========================================
+ Hits         1536     1538       +2     
  Misses       3806     3806              
  Partials      196      196
Impacted Files Coverage Δ
pkg/minikube/cluster/cluster.go 31.52% <100%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa7ddbc...866c0e6. Read the comment docs.

@r2d4
r2d4 commented Nov 22, 2017
Copy link
Copy Markdown
Contributor

@minikube-bot ok to teset

@dlorenc
dlorenc commented Nov 24, 2017
Copy link
Copy Markdown
Contributor

@minikube-bot test this please

@dlorenc
dlorenc commented Nov 24, 2017
Copy link
Copy Markdown
Contributor

We could avoid making this a flag and set it by default for all platforms except Windows, if we think it won't work there. We'd have to move createVirtualboxHost (or a small part of it) from cluster.go into the platform-specific cluster_{darwin|windows|linux}.go files.

@dlorenc
dlorenc commented Nov 27, 2017
Copy link
Copy Markdown
Contributor

Actually this looks good - it looks like any recent version of windows supports this so it should be safe.

@dlorenc
dlorenc merged commit bbb53c9 into kubernetes:master Nov 27, 2017
@ijl
ijl deleted the vbox-virtio branch December 4, 2017 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0