8000 Add verbose logging by r2d4 · Pull Request #2078 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add verbose logging - #2078

Merged
r2d4 merged 1 commit into
kubernetes:masterfrom
r2d4:verbose-logging
Oct 17, 2017
Merged

r2d4 merged 1 commit into
kubernetes:masterfrom
r2d4:verbose-logging

Conversation

@r2d4
@r2d4 r2d4 commented Oct 17, 2017
Copy link
Copy Markdown
Contributor

fixes #2053

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2017
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2078 into master will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2078      +/-   ##
==========================================
+ Coverage    28.9%   28.92%   +0.01%     
==========================================
  Files          81       81              
  Lines        5304     5311       +7     
==========================================
+ Hits         1533     1536       +3     
- Misses       3578     3582       +4     
  Partials      193      193
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 9.81% <0%> (-0.13%) ⬇️
pkg/minikube/cluster/cluster.go 31.05% <100%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ccaae8...8894ed7. Read the comment docs.

@r2d4
r2d4 merged commit 3358402 into kubernetes:master Oct 17, 2017
@r2d4
r2d4 deleted the verbose-logging branch October 17, 2017 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minikube should log where it gets config options from on start

4 participants

0