8000 Enable cache image for Windows · Pull Request #2000 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Enable cache image for Windows - #2000

Merged
r2d4 merged 2 commits into
masterfrom
unknown repository
Oct 3, 2017
Merged

r2d4 merged 2 commits into
masterfrom
unknown repository

Conversation

@ghost
@ghost ghost commented Sep 23, 2017
Copy link
Copy Markdown

Enable the cache image feature disabled by PR /pull/1982.

Use the wmic command to change a drive letter to a volume name (C:\ -> \\?\Volume{GUID}\).

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2017
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@codecov-io
codecov-io commented Sep 23, 2017 •
Copy link
Copy Markdown

Codecov Report

Merging #2000 into master will decrease coverage by 0.17%.
The diff coverage is 12.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2000      +/-   ##
==========================================
- Coverage   29.87%   29.69%   -0.18%     
==========================================
  Files          77       77              
  Lines        4760     4842      +82     
==========================================
+ Hits         1422     1438      +16     
- Misses       3158     3218      +60     
- Partials      180      186       +6
Impacted Files Coverage Δ
pkg/minikube/machine/cache_images.go 10.05% <12.82%> (+7.86%) ⬆️
pkg/localkube/localkube.go 44.23% <0%> (-7.7%) ⬇️
pkg/localkube/ready.go 48% <0%> (-5.85%) ⬇️
pkg/localkube/apiserver.go 0% <0%> (ø) ⬆️
cmd/minikube/cmd/start.go 9.93% <0%> (ø) ⬆️
pkg/localkube/kubelet.go 0% <0%> (ø) ⬆️
pkg/localkube/storage_provisioner.go 0% <0%> (ø) ⬆️
pkg/localkube/proxy.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685f570...7f8f3bb. Read the comment docs.

@r2d4
r2d4 commented Sep 23, 2017
Copy link
Copy Markdown
Contributor

@minikube-bot ok to test

@@ -162,6 +189,18 @@ func getSrcRef(image string) (types.ImageReference, error) {
}

func getDstRef(image, dst string) (types.ImageReference, error) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add a few unit tests here for the new behavior?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will add the unit tests from now.

8000
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2017
@r2d4
r2d4 merged commit 8e319bd into kubernetes:master Oct 3, 2017
@ghost
ghost deleted the enable-cache-image-for-windows branch October 3, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0