8000 fixing debian and arch concurrent multiarch builds by Jorropo · Pull Request #9998 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

fixing debian and arch concurrent multiarch builds - #9998

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
Jorropo:fix/debian-multiarch-bundeling
Jan 25, 2021
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
Jorropo:fix/debian-multiarch-bundeling

Conversation

@Jorropo
@Jorropo Jorropo commented Dec 18, 2020
Copy link
Copy Markdown
Contributor

fixes #9995

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 18, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. 8000

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 18, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @Jorropo!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 18, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Jorropo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 18, 2020
@Jorropo
Jorropo force-pushed the fix/debian-multiarch-bundeling branch from c8b85cb to 08ff25b Compare December 18, 2020 06:47
@Jorropo Jorropo changed the title fix: #9995 debian concurrent multiarch builds fix: debian concurrent multiarch builds Dec 18, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 18, 2020
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@Jorropo Jorropo changed the title fix: debian concurrent multiarch builds fixing debian concurrent multiarch builds Dec 18, 2020
@afbjorklund
Copy link
Copy Markdown
Collaborator

I'm thinking now might be the time to introduce a variable for it ? :-)

Also need to fix the rpm build, which has same issue as deb build

@Jorropo
Jorropo force-pushed the fix/debian-multiarch-bundeling branch from 08ff25b to 6220233 Compare December 18, 2020 06:51
Comment thread Makefile Resolved
@Jorropo
Jorropo force-pushed the fix/debian-multiarch-bundeling branch from 6220233 to 02f646e Compare December 18, 2020 06:59
@Jorropo
Jorropo requested a review from afbjorklund December 18, 2020 06:59
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2020
@Jorropo
Jorropo force-pushed the fix/debian-multiarch-bundeling branch from 02f646e to b12e3da Compare December 18, 2020 07:04
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 18, 2020
@Jorropo Jorropo changed the title fixing debian concurrent multiarch builds fixing debian and arch concurrent multiarch builds Dec 18, 2020
Comment thread Makefile Resolved
@afbjorklund afbjorklund left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Almost there, just one little byte left

Comment thread Makefile Resolved
@afbjorklund
afbjorklund commented Dec 19, 2020 •
Copy link
Copy Markdown
Collaborator

Reproducer:

$ DEB_VERSION=$(make deb_version)
$ RPM_VERSION=$(make rpm_version)
$ make -j   "out/minikube_${DEB_VERSION}-0_amd64.deb"   "out/minikube_${DEB_VERSION}-0_arm64.deb" \
            "out/minikube-${RPM_VERSION}-0.x86_64.rpm"   "out/minikube-${RPM_VERSION}-0.aarch64.rpm"
cp -r installers/linux/deb/minikube_deb_template out/minikube_1.16.0-amd64
cp -r installers/linux/deb/minikube_deb_template out/minikube_1.16.0-arm64
cp -r installers/linux/rpm/minikube_rpm_template 
cp -r installers/linux/rpm/minikube_rpm_template 
cp: missing destination file operand after 'installers/linux/rpm/minikube_rpm_template'
Try 'cp --help' for more information.

Need two different variables, and probably place them at the top-level (no, not with arch)

@Jorropo
Jorropo requested a review from afbjorklund December 20, 2020 03:08
@Jorropo
Jorropo force-pushed the fix/debian-multiarch-bundeling branch 2 times, most recently from 4265064 to 5d90968 Compare December 20, 2020 03:09
Signed-off-by: Jorropo <jorropo.pgm@gmail.com>
@Jorropo
Jorropo force-pushed the fix/debian-multiarch-bundeling branch from 5d90968 to c14734c Compare December 20, 2020 03:09
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, Jorropo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2020
@medyagh
medyagh commented Jan 20, 2021
Copy link
Copy Markdown
Member

@ilya-zuyev is this trying to fix same problem as #10004 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minikube_1.16.0-0_amd64.deb: package architecture (arm64) does not match system (amd64)

7 participants

0