Repository navigation
fixing debian and arch concurrent multiarch builds - #9998
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. 8000 It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @Jorropo! |
|
Hi @Jorropo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c8b85cb to
08ff25b
Compare
|
Can one of the admins verify this patch? |
|
I'm thinking now might be the time to introduce a variable for it ? :-) Also need to fix the rpm build, which has same issue as deb build |
08ff25b to
6220233
Compare
6220233 to
02f646e
Compare
02f646e to
b12e3da
Compare
b12e3da to
518489a
Compare
There was a problem hiding this comment.
Looking good! Almost there, just one little byte left
|
Reproducer: $ DEB_VERSION=$(make deb_version)
$ RPM_VERSION=$(make rpm_version)
$ make -j "out/minikube_${DEB_VERSION}-0_amd64.deb" "out/minikube_${DEB_VERSION}-0_arm64.deb" \
"out/minikube-${RPM_VERSION}-0.x86_64.rpm" "out/minikube-${RPM_VERSION}-0.aarch64.rpm"
cp -r installers/linux/deb/minikube_deb_template out/minikube_1.16.0-amd64
cp -r installers/linux/deb/minikube_deb_template out/minikube_1.16.0-arm64
cp -r installers/linux/rpm/minikube_rpm_template
cp -r installers/linux/rpm/minikube_rpm_template
cp: missing destination file operand after 'installers/linux/rpm/minikube_rpm_template'
Try 'cp --help' for more information.Need two different variables, |
4265064 to
5d90968
Compare
Signed-off-by: Jorropo <jorropo.pgm@gmail.com>
5d90968 to
c14734c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, Jorropo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ilya-zuyev is this trying to fix same problem as #10004 ? |
fixes #9995