Repository navigation
fix ip node retrieve for none driver - #9986
Conversation
|
/ok-to-test |
There was a problem hiding this comment.
It seems like this shouldn't be a special case -- that cc.Nodes should have the correct data in it.
That said, I'm approving this to unblock the release.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
kvm2 Driver Times for Minikube (PR 9986): 56.5s 57.8s 58.2s Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 9986): 23.7s 23.0s 23.8s Averages Time Per Log Details |
cc.Nodes does have the correct info, it's the request default of empty that's bad, but only for the none driver. |
We hardcode a node name for the none driver, which broke minikube ip when we added the
node.Retrievecall to it.