Repository navigation
Added validation for --i 8000 nsecure-registry values - #9977
Conversation
|
Hi @kadern0. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch? |
|
|
||
| // This function validates that the --insecure-registry follows one of the following formats: | ||
| // "<ip>:<port>" "<hostname>:<port>" "<network>/<netmask>" | ||
| func ValidateInsecureRegistry() { |
There was a problem hiding this comment.
this should be a private function -- and probably moved to start_flags.go.
There was a problem hiding this comment.
Agree with the private function, about the location I've placed it under the "validateRegistryMirror" function since they do pretty much the same. To me it makes sense having both together, what do you think?
| insecureRegistry []string | ||
| apiServerNames []string | ||
| apiServerIPs []net.IP | ||
| hostRe = regexp.MustCompile(`[\w\.-]+`) |
There was a problem hiding this comment.
Do you still want me to add the comment?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadern0, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Why hostname without port is not allowed? It works fine in previous versions. |
|
@crossdot we are discussing about this on the issue's URL. |
Fixes 8790
Original reported behavior (slightly summarized):
New behavior:
Additional validations: