8000 wsl2: log warning if br_netfilter cannot be enabled rather than fatally exit by tstromberg · Pull Request #9932 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

wsl2: log warning if br_netfilter cannot be enabled rather than fatally exit - #9932

Merged
tstromberg merged 1 commit into
masterfrom
br_netfilter2
Dec 11, 2020
Merged

tstromberg merged 1 commit into
masterfrom
br_netfilter2

Conversation

@tstromberg
@tstromberg tstromberg commented Dec 11, 2020 •
Copy link
Copy Markdown
Contributor

Fixes #9837

Also moved enableIPForwarding function to crio.go, as CRIO is the only runtime we do this with.

Confirmed by testing locally using Docker & WSL2.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2020
@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix unit test

@tstromberg
tstromberg merged commit a60e264 into master Dec 11, 2020
@medyagh
medyagh deleted the br_netfilter2 branch January 27, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crio + docker + wsl2: Module br_netfilter not found in directory /lib/modules/4.19.128-microsoft-standard

3 participants

0