8000 Added sub-step logging to adm init step on start by spowelljr · Pull Request #9904 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Added sub-step logging to adm init step on start - #9904

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
spowelljr:addRunStartToCommandRunner
Dec 16, 2020
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
spowelljr:addRunStartToCommandRunner

Conversation

@spowelljr
Copy link
Copy Markdown
Member

Fixes: #9779

Added StartCmd and WaitCmd to CommandRunner interface to allow real-time streaming of logs.
Used these two new methods to add sub-step logging to adm init on start, these steps also output to JSON.

😄  minikube v1.15.1 on Darwin 10.15.7
✨  Automatically selected the docker driver. Other choices: hyperkit, virtualbox
👍  Starting control plane node minikube in cluster minikube
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.19.4 on Docker 19.03.13 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔎  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @spowelljr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 9, 2020
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@spowelljr
spowelljr force-pushed the addRunStartToCommandRunner branch from 1f34c5f to cf35c15 Compare December 9, 2020 23:27
Comment thread pkg/minikube/cruntime/cruntime.go Resolved
Comment thread pkg/minikube/cruntime/cruntime_test.go Resolved
@spowelljr
spowelljr force-pushed the addRunStartToCommandRunner branch from cf35c15 to b33f40d Compare December 11, 2020 00:44
@spowelljr
spowelljr force-pushed the addRunStartToCommandRunner branch 2 times, most recently from 7adccf9 to 3bb8810 Compare December 11, 2020 17:14
@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure to run make generate-docs after the PR

@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spowelljr
spowelljr force-pushed the addRunStartToCommandRunner branch 2 times, most recently from f92c383 to 9cf6e82 Compare December 11, 2020 23:55
Comment thread test/integration/error_spam_test.go Resolved
@spowelljr
spowelljr force-pushed the addRunStartToCommandRunner branch 2 times, most recently from 06a8f38 to 6f635ec Compare December 12, 2020 00:55
@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding unit test and great work, I approve this PR after all other reviews are approved.

final approve leaving for @tstromberg or @priyawadhwa

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2020
@spowelljr
spowelljr force-pushed the addRunStartToCommandRunner branch 2 times, most recently from a6509d1 to d3f93ae Compare December 14, 2020 22:03
@tstromberg tstromberg left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor nit.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr
spowelljr force-pushed the addRunStartToCommandRunner branch from d3f93ae to 5f0144a Compare December 15, 2020 23:59
@tstromberg
tstromberg merged commit 4acc0c8 into kubernetes:master Dec 16, 2020
@spowelljr
spowelljr deleted the addRunStartToCommandRunner branch June 28, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stream kubeadm progress logs

6 participants

0