8000 added statusName for kubeconfig by tharun208 · Pull Request #9888 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

added statusName for kubeconfig - #9888

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
tharun208:feat/kubeconfig_status_name
Dec 11, 2020
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
tharun208:feat/kubeconfig_status_name

Conversation

@tharun208
@tharun208 tharun208 commented Dec 9, 2020 •
Copy link
Copy Markdown
Contributor

Added statusName for kubeconfig in status

FYI, statusName is not displayed in default minikube status. So, adding output for --layout=cluster

Before output of ./minikube-darwin-amd64 status --output json --layout cluster,
Screen Shot 2020-12-10 at 11 52 25 AM

After:
Screen Shot 2020-12-10 at 11 54 04 AM

Fixes #8921

Signed-off-by: Tharun rajendrantharun@live.com

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @tharun208. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2020
Signed-off-by: Tharun <rajendrantharun@live.com>
@tharun208
tharun208 force-pushed the feat/kubeconfig_status_name branch from b77fffd to af3f1cf Compare December 9, 2020 05:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 9, 2020
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tharun208 do u mind adding in the PR description the output before and after this PR ?

for both normal status and --output=json formats ?

@tharun208
Copy link
Copy Markdown
Contributor Author

@tharun208 do u mind adding in the PR description the output before and after this PR ?

for both normal status and --output=json formats ?

@medyagh updated in the description.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tharun208, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2020
@tstromberg
tstromberg merged commit 86b9397 into kubernetes:master Dec 11, 2020
@tharun208
tharun208 deleted the feat/kubeconfig_status_name branch December 11, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

status with cluster layout: kubeconfig StatusName is empty

5 participants

0