8000 Fix podman network inspect format and error by afbjorklund · Pull Request #9866 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Fix podman network inspect format and error - #9866

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
afbjorklund:podman-network-fix
Dec 11, 2020
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
afbjorklund:podman-network-fix

Conversation

@afbjorklund
Copy link
Copy Markdown
Collaborator

Somehow this ended up with the docker network inspect format,
instead of the CNI based one used by podman network inspect ?

Also add a check for when trying to name the cluster "podman",
which runs into trouble (same as docker driver with name "bridge")

@afbjorklund
afbjorklund requested a review from medyagh December 5, 2020 17:09
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2020
@afbjorklund
Copy link
Copy Markdown
Collaborator Author

Left-overs from #9716, which actually caused the whole thing to come crashing down...

✨  Using the podman (experimental) driver based on user configuration
👍  Starting control plane node podman in cluster podman
🔥  Creating podman container (CPUs=2, Memory=7900MB) ...
panic: runtime error: index out of range [1] with length 1

Comment thread pkg/drivers/kic/oci/network_create.go Resolved
Comment thread pkg/drivers/kic/oci/network_create.go Resolved
Comment thread pkg/drivers/kic/oci/network_create.go Resolved
@medyagh medyagh changed the title Fix podman network inspect format and error wip: Fix podman network inspect format and error Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2020
Somehow this ended up with the docker network inspect format,
instead of the CNI based one used by podman network inspect ?
@afbjorklund afbjorklund changed the title wip: Fix podman network inspect format and error Fix podman network inspect format and error Dec 10, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tstromberg merged commit b4bf2bd into kubernetes:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0