Repository navigation
Set 'currentstep' for PullingBaseImage json event - #9844
Conversation
|
/ok-to-test |
|
kvm2 Driver |
| if err != nil { | ||
| t.Errorf("failed to download only. args: %q %v", args, err) | ||
| } | ||
| s := bufio.NewScanner(bytes.NewReader(rt.Stdout.Bytes())) |
There was a problem hiding this comment.
This could potentially be a Subtest
another t.Run with a name like "validateStepNumber"
so when it fails we know exaclty what part of download only test failed
example of adding subtests in TestStartStop test
https://github.com/medyagh/minikube/blob/b6ee8f2f6777921a87959df78e2497fafc9c5864/test/integration/start_stop_delete_test.go#L100
|
kvm2 Driver Times for Minikube (PR 9844): 62.0s 61.9s 63.9s Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 9844): 28.4s 29.4s 29.9s Averages Time Per Log Details |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ilya-zuyev, priyawadhwa, sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #9754
Before:
After: