8000 Fix missing InitialSetup in `node start` by lingsamuel · Pull Request #9832 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Fix missing In 8000 itialSetup in node start - #9832

Merged
medyagh merged 1 commit into
kubernetes:masterfrom
lingsamuel:fix-node-start-step
Dec 4, 2020
Merged

medyagh merged 1 commit into
kubernetes:masterfrom
lingsamuel:fix-node-start-step

Conversation

@lingsamuel
Copy link
Copy Markdown
Contributor

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

Fixes #9830

In start command, we call register.Reg.SetStep(register.InitialSetup) in displayVersion, it calls register.Reg.SetStep(register.InitialSetup) but node start didn't, makes register.Reg.SetStep(register.StartingNode) display a error message.

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @lingsamuel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 3, 2020
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@medyagh medyagh left a comment •
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lingsamuel thanks for this PR, do you mind pasting the PR description the before/after this PR output ?

@priyawadhwa priyawadhwa left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingsamuel, medyagh, priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [medyagh,priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
medyagh commented Dec 4, 2020
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9832): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9832/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9832/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9832): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9832/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9832/minikube: exec format error

@lingsamuel
8000
Copy link
Copy Markdown
Contributor Author

Sorry, I am a little confused. What do you mean by "PR output"?

@medyagh
medyagh merged commit 0a4f293 into kubernetes:master Dec 4, 2020
@lingsamuel
lingsamuel deleted the fix-node-start-step branch December 31, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minikube node start logs unexpected first step

6 participants

0