8000 Add support for restoring existing podman env by afbjorklund · Pull Request #9801 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

8000 Add support for restoring existing podman env - #9801

Merged
medyagh merged 2 commits into
kubernetes:masterfrom
afbjorklund:podman-env-existing
Dec 8, 2020
Merged

medyagh merged 2 commits into
kubernetes:masterfrom
afbjorklund:podman-env-existing

Conversation

@afbjorklund
Copy link
Copy Markdown
Collaborator

If user had a podman environment configured before podman-env,
restore it on unset (similar to existing code for docker-env)

Only do this for podman v2, not for the deprecated podman v1...
And yes, it is called CONTAINER_HOST and not PODMAN_HOST

If user had a podman environment configured before podman-env,
restore it on unset (similar to existing code for docker-env)
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 29, 2020
@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR needs lint please

@medyagh
medyagh merged commit 0898ca2 into kubernetes:master Dec 8, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0