8000 Add JSON output to stop, pause and unpause by priyawadhwa · Pull Request #9576 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add JSON output to stop, pause and unpause - #9576

Merged
medyagh merged 8 commits into
kubernetes:masterfrom
priyawadhwa:json-output-stop
Oct 30, 2020
Merged

medyagh merged 8 commits into
kubernetes:masterfrom
priyawadhwa:json-output-stop

Conversation

@priyawadhwa
@priyawadhwa priyawadhwa commented Oct 28, 2020 •
Copy link
Copy Markdown

Closes #9258, still need to do pause and unpause

Output now:

$ minikube stop --output json
{"data":{"currentstep":"0","message":"Stopping node \"minikube\"  ...","name":"Stopping","totalsteps":"2"},"datacontenttype":"application/json","id":"d8bdbcb7-c8d7-445a-a454-8e618b7b00ba","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.step"}
{"data":{"currentstep":"1","message":"Powering off \"minikube\" via SSH ...","name":"PowerOff","totalsteps":"2"},"datacontenttype":"application/json","id":"7d28072b-f715-4a7f-88d6-98830e7a31bf","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.step"}
{"data":{"currentstep":"2","message":"1 nodes stopped.","name":"Done","totalsteps":"2"},"datacontenttype":"application/json","id":"9615b7bd-593b-4f38-a19c-f8d673d4b8f7","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.step"}
$ minikube pause --output json
{"data":{"currentstep":"0","message":"Pausing node minikube ...","name":"Pausing","totalsteps":"1"},"datacontenttype":"application/json","id":"ad2e6b5b-72d2-400a-8c80-d9d4d2b117aa","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.step"}
{"data":{"currentstep":"1","message":"Paused 14 containers in: kube-system, kubernetes-dashboard, storage-gluster, istio-operator","name":"Done","totalsteps":"1"},"datacontenttype":"application/json","id":"e6b53def-cf44-4509-bc64-e9948480b757","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.step"}
$ minikube unpause --output json
{"data":{"currentstep":"0","message":"Unpausing node minikube ...","name":"Unpausing","totalsteps":"1"},"datacontenttype":"application/json","id":"a75b2d42-fe88-4618-99f3-ca8bf165dc8b","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.step"}
{"data":{"currentstep":"1","message":"Unpaused 14 containers in: kube-system, kubernetes-dashboard, storage-gluster, istio-operator","name":"Done","totalsteps":"1"},"datacontenttype":"application/json","id":"5e12ee69-68fc-4230-81ce-25a1be524de2","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.step"}

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2020
@priyawadhwa
Copy link
Copy Markdown
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9576): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9576/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9576/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9576): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9576/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9576/minikube: exec format error

@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, unit test needs fix

@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
Times for minikube: 61.2s 59.4s 62.2s
Average time for minikube: 60.9s

Times for Minikube (PR 9576): 57.5s 59.9s 62.0s
Average time for Minikube (PR 9576): 59.8s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9576) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.2 on Debian   | 0.0s     | 0.0s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.4s    | 34.3s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 22.9s    | 23.0s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.5s     | 2.1s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.4s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 30.3s 27.8s 27.5s
Average time for minikube: 28.5s

Times for Minikube (PR 9576): 29.4s 28.7s 29.8s
Average time for Minikube (PR 9576): 29.3s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9576) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.2 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.5s     | 9.0s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 17.3s    | 18.8s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.2s     | 1.0s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2020
@priyawadhwa priyawadhwa changed the title Add JSON output to minikube stop Add JSON output to stop, pause and unpause Oct 28, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
Times for minikube: 61.4s 59.6s 60.9s
Average time for minikube: 60.6s

Times for Minikube (PR 9576): 63.5s 56.1s 61.1s
Average time for Minikube (PR 9576): 60.2s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9576) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.2 on Debian   | 0.0s     | 0.0s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 35.5s    | 34.4s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.3s    | 24.2s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.5s     | 1.5s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.3s     |                    |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.1s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 28.5s 29.5s 27.9s
Average time for minikube: 28.6s

Times for Minikube (PR 9576): 28.3s 29.8s 27.9s
Average time for Minikube (PR 9576): 28.7s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9576) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.2 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.9s     | 9.2s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 17.9s    | 18.0s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.0s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.3s     | 0.1s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.1s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
Times for minikube: 63.0s 61.0s 60.9s
Average time for minikube: 61.6s

Times for Minikube (PR 9576): 61.7s 55.9s 57.9s
Average time for Minikube (PR 9576): 58.5s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9576) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.2 on Debian   | 0.0s     | 0.0s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.2s    | 32.7s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.4s    | 23.9s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.8s     | 1.6s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.3s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 28.3s 28.5s 28.5s
Average time for minikube: 28.4s

Times for Minikube (PR 9576): 29.4s 28.6s 29.1s
Average time for Minikube (PR 9576): 29.0s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9576) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.2 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.2s     | 9.1s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 17.7s    | 18.4s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.1s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
Times for minikube: 63.6s 64.7s 62.1s
Average time for minikube: 63.5s

Times for Minikube (PR 9576): 62.7s 61.4s 61.8s
Average time for Minikube (PR 9576): 62.0s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9576) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.2 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.9s    | 36.3s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 24.1s    | 23.5s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 1.7s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.8s     | 0.4s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.8s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |             
8000
       |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 30.2s 28.7s 30.8s
Average time for minikube: 29.9s

Times for Minikube (PR 9576): 30.1s 30.0s 30.2s
Average time for Minikube (PR 9576): 30.1s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9576) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.2 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.4s     | 9.2s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 18.9s    | 19.3s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.2s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@medyagh
medyagh merged commit a67acc2 into kubernetes:master Oct 30, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [medyagh,priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include JSON Output as a standard option.

4 participants

0