8000 Enable TCP Path MTU Discovery when an ICMP black hole is detected by tstromberg · Pull Request #9537 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Enable TCP Path MTU Discovery when an ICMP black hole is detected - #9537

Merged
tstromberg merged 2 commits into
kubernetes:masterfrom
tstromberg:mtu-probing
Oct 28, 2020
Merged

tstromberg merged 2 commits into
kubernetes:masterfrom
tstromberg:mtu-probing

Conversation

@tstromberg
@tstromberg tstromberg commented Oct 23, 2020 •
Copy link
Copy Markdown
Contributor

Partial fix for #9528 - the longer-term fix will come from #9530

This lets docker pull work when the network MTU is misconfigured. There are no apparent downsides to this approach, as best as I can tell. Here's the documentation from https://www.kernel.org/doc/Documentation/networking/ip-sysctl.txt

tcp_mtu_probing - INTEGER
	Controls TCP Packetization-Layer Path MTU Discovery.  Takes three
	values:
	  0 - Disabled (DEFAULT)
	  1 - Disabled by default, enabled when an ICMP black hole detected
	  2 - Always enabled, use initial MSS of tcp_base_mss.

NOTE That tcp_base_mss defaults to 1024. I believe that 1 is the best default going forward.

I can confirm that this allows minikube ssh "docker pull golang:1.15" to work properly on Cloud Shell.

Old behavior

minikube ssh "sysctl net.ipv4.tcp_mtu_probing"                                                                                                                              net.ipv4.tcp_mtu_probing = 0

New behavior

minikube ssh "sysctl net.ipv4.tcp_mtu_probing"
net.ipv4.tcp_mtu_probing = 1

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 23, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 23, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [priyawadhwa,tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg tstromberg changed the title Set net.ipv4.tcp_mtu_probing = 1 kicbase: Set net.ipv4.tcp_mtu_probing = 1 Oct 23, 2020
@medyagh medyagh left a comment •
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it better to be added to both ISO and kicbase at same time?
this PR would need a new kic-base image, that I believe has some other changes, for a point release we might wanna avoid that since we have not tested the head kicbase

@tstromberg
Copy link
Copy Markdown
Contributor Author

isn't it better to be added to both ISO and kicbase at same time?
this PR would need a new kic-base image, that I believe has some other changes, for a point release we might wanna avoid that since we have not tested the head kicbase

Done.

@tstromberg tstromberg changed the title kicbase: Set net.ipv4.tcp_mtu_probing = 1 Enable TCP Path MTU Discovery when an ICMP black hole is detected Oct 23, 2020
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #9537 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9537      +/-   ##
==========================================
+ Coverage   29.08%   29.11%   +0.03%     
==========================================
  Files         171      172       +1     
  Lines       10443    10461      +18     
==========================================
+ Hits         3037     3046       +9     
- Misses       6983     6990       +7     
- Partials      423      425       +2     
Impacted Files Coverage Δ
cmd/minikube/cmd/start_flags.go 47.04% <0.00%> (-0.72%) ⬇️
cmd/minikube/cmd/start.go 9.38% <0.00%> (-0.15%) ⬇️
pkg/addons/addons.go 35.26% <0.00%> (ø)
pkg/minikube/driver/install.go 8.95% <0.00%> (ø)
pkg/minikube/driver/version.go 73.33% <0.00%> (ø)

@tstromberg
tstromberg merged commit 96da944 into kubernetes:master Oct 28, 2020
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.11%. Comparing base (e18b312) to head (71af47a).
⚠️ Report is 15226 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9537      +/-   ##
==========================================
+ Coverage   29.08%   29.11%   +0.03%     
==========================================
  Files         171      172       +1     
  Lines       10443    10461      +18     
==========================================
+ Hits         3037     3046       +9     
- Misses       6983     6990       +7     
- Partials      423      425       +2     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0