Repository navigation
Enable TCP Path MTU Discovery when an ICMP black hole is detected - #9537
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Done. |
Codecov Report
@@ Coverage Diff @@
## master #9537 +/- ##
==========================================
+ Coverage 29.08% 29.11% +0.03%
==========================================
Files 171 172 +1
Lines 10443 10461 +18
==========================================
+ Hits 3037 3046 +9
- Misses 6983 6990 +7
- Partials 423 425 +2
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9537 +/- ##
==========================================
+ Coverage 29.08% 29.11% +0.03%
==========================================
Files 171 172 +1
Lines 10443 10461 +18
==========================================
+ Hits 3037 3046 +9
- Misses 6983 6990 +7
- Partials 423 425 +2 🚀 New features to boost your workflow:
|
Partial fix for #9528 - the longer-term fix will come from #9530
This lets
docker pullwork when the network MTU is misconfigured. There are no apparent downsides to this approach, as best as I can tell. Here's the documentation from https://www.kernel.org/doc/Documentation/networking/ip-sysctl.txtNOTE That
tcp_base_mssdefaults to 1024. I believe that 1 is the best default going forward.I can confirm that this allows
minikube ssh "docker pull golang:1.15"to work properly on Cloud Shell.Old behavior
New behavior