Repository navigation
Ad 8000 d support for podman v2 to podman-env command - #9535
Merged
Merged
Conversation
Podman v1 (like 1.9.3) uses the varlink bridge, while podman v2 (like 2.1.x) uses a REST API. Both are using ssh for their transport, but the environment variables exported are different.
Travis tests have failedHey @afbjorklund, 1st Buildmake testTravisBuddy Request Identifier: 75c013a0-1519-11eb-aff7-dd8cbeb067cc |
Collaborator
Author
|
Dear @TravisBuddy it is just a Travis flake |
This was referenced Oct 24, 2020
priyawadhwa
reviewed
Oct 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #9535 +/- ##
==========================================
+ Coverage 29.11% 29.21% +0.09%
==========================================
Files 172 172
Lines 10461 10556 +95
==========================================
+ Hits 3046 3084 +38
- Misses 6990 7047 +57
Partials 425 425
|
afbjorklund
force-pushed
the
podman2-env
branch
from
November 1, 2020 14:14
a341305 to
bfefa72
Compare
medyagh
approved these changes
Nov 6, 2020
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Podman v1 (like 1.9.3) uses the varlink bridge,
while podman v2 (like 2.1.x) uses a REST API.
Both are using ssh for their transport, but the
environment variables exported are different.
Not using
sudoanymore, so user needs root access.See #8596 for how to set that up for the "docker" user
Tested OK with 1.9.3 and 2.1.1 minikube profiles.
But don't recommend using podman 2.0.x (at all)