8000 Add support for podman v2 to podman-env command by afbjorklund · Pull Request #9535 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Ad 8000 d support for podman v2 to podman-env command - #9535

Merged
medyagh merged 3 commits into
kubernetes:masterfrom
afbjorklund:podman2-env
Nov 6, 2020
Merged

medyagh merged 3 commits into
kubernetes:masterfrom
afbjorklund:podman2-env

Conversation

@afbjorklund
@afbjorklund afbjorklund commented Oct 23, 2020 •
Copy link
Copy Markdown
Collaborator

Podman v1 (like 1.9.3) uses the varlink bridge,
while podman v2 (like 2.1.x) uses a REST API.

Both are using ssh for their transport, but the
environment variables exported are different.

Not using sudo anymore, so user needs root access.

See #8596 for how to set that up for the "docker" user

Tested OK with 1.9.3 and 2.1.1 minikube profiles.

But don't recommend using podman 2.0.x (at all)

Podman v1 (like 1.9.3) uses the varlink bridge,
while podman v2 (like 2.1.x) uses a REST API.

Both are using ssh for their transport, but the
environment variables exported are different.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 23, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@TravisBuddy
Copy link
Copy Markdown

Travis tests have failed

Hey @afbjorklund,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.15.2.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.15.2.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.14.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.14.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="8174beaaeb045587a59df28259be970d1f4b229b" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.30.0'
golangci/golangci-lint crit unable to find 'v1.30.0' - use 'latest' or see https://github.com/golangci/golangci-lint/releases for details
Makefile:416: recipe for target 'out/linters/golangci-lint-v1.30.0' failed
make[1]: *** [out/linters/golangci-lint-v1.30.0] Error 1
= go mod ================================================================
ok
= boilerplate ===========================================================
ok
Makefile:315: recipe for target 'test' failed
make: *** [test] Error 4
TravisBuddy Request Identifier: 75c013a0-1519-11eb-aff7-dd8cbeb067cc

@afbjorklund
Copy link
Copy Markdown 8000
Collaborator Author

Dear @TravisBuddy it is just a Travis flake

Comment thread cmd/minikube/cmd/podman-env.go Resolved
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #9535 into master will increase coverage by 0.09%.
The diff coverage is 64.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9535      +/-   ##
==========================================
+ Coverage   29.11%   29.21%   +0.09%     
==========================================
  Files         172      172              
  Lines       10461    10556      +95     
==========================================
+ Hits         3046     3084      +38     
- Misses       6990     7047      +57     
  Partials      425      425              
Impacted Files Coverage Δ
cmd/minikube/cmd/podman-env.go 45.90% <64.91%> (+12.56%) ⬆️
cmd/minikube/cmd/root.go 43.57% <0.00%> (-3.72%) ⬇️
pkg/minikube/machine/stop.go 27.77% <0.00%> (-0.80%) ⬇️
cmd/minikube/cmd/config/profile_list.go 2.38% <0.00%> (-0.19%) ⬇️
cmd/minikube/cmd/start_flags.go 47.04% <0.00%> (ø)
pkg/drivers/kic/oci/network_create.go 0.00% <0.00%> (ø)
pkg/minikube/out/register/register.go 79.48% <0.00%> (ø)
cmd/minikube/cmd/stop.go 5.76% <0.00%> (+1.76%) ⬆️
cmd/minikube/cmd/unpause.go 7.50% <0.00%> (+2.23%) ⬆️
cmd/minikube/cmd/pause.go 8.57% <0.00%> (+2.51%) ⬆️
... and 1 more

@medyagh
medyagh merged commit 7747655 into kubernetes:master Nov 6, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0