Repository navigation
Remove hard-coded list of valid cgroupfs mountpoints to bind mount - #9508
Conversation
|
/ok-to-test |
|
kvm2 Driver Times for Minikube (PR 9508): 61.7s 60.6s 60.2s Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 9508): 27.6s 28.7s 28.2s Averages Time Per Log Details |
thanks for this pr, btw fyi, ok to test wouldn't work on this PR, since it is a different image. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Likely fixes #9304
The TL;DR is that I had previously created an overly strict list of expected mountpaths. As we found more and more corner cases, the regexp got more convoluted. With this GitHub Actions environment, an additional new possibility was found, so this PR generalizes the regexp.
Tested using:
docker build -t kicbase:experiment deploy/kicbase; minikube delete; minikube start --base-image=kicbase:experiment --driver=dockerDocker Desktop
Cloud Shell