Repository navigation
new flag --namespace for activating non default kubeconfig context - #9506
Conversation
|
Hi @prezha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Travis tests have failedHey @prezha, 1st Buildmake testTravisBuddy Request Identifier: ca2bbab0-1335-11eb-8230-47bfa5f272e1 |
|
Can one of the admins verify this patch? |
Travis tests have failedHey @prezha, 1st Buildmake testTravisBuddy Request Identifier: f1af0e80-13fc-11eb-a355-c174999d48b2 |
9775ea1 to
2e877c0
Compare
Travis tests have failedHey @prezha, 1st Buildmake testTravisBuddy Request Identifier: 8b6a2900-1458-11eb-ac79-47417aa7eb7e |
Codecov Report
@@ Coverage Diff @@
## master #9506 +/- ##
==========================================
+ Coverage 29.47% 29.48% +0.01%
==========================================
Files 173 173
Lines 10736 10741 +5
==========================================
+ Hits 3164 3167 +3
- Misses 7123 7125 +2
Partials 449 449
|
|
it took me some time to determine why travis tests have been failing with: as bottom line: upgrade of |
|
/ok-to-test |
|
kvm2 Driver Times for Minikube (PR 9506): 63.5s 63.1s 62.3s Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 9506): 28.9s 29.9s 29.8s Averages Time Per Log Details |
upgrade spf13/cobra from v1.0.0 to v1.1.1 will probably have side-effects and tests failing, ie:
'make test' suddently starting to report issues, like:
--- FAIL: TestGenerateDocs (0.02s)
--- FAIL: TestGenerateDocs/pause (0.00s)
generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation: strings.Join({
... // 9 identical lines
"pause Kubernetes",
"",
+ "### Synopsis",
+ "",
+ "pause Kubernetes",
+ "",
"```",
"minikube pause [flags]",
... // 30 identical lines
}, "\n")
--- FAIL: TestGenerateDocs/unpause (0.01s)
generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation: strings.Join({
... // 9 identical lines
"unpause Kubernetes",
"",
+ "### Synopsis",
+ "",
+ "unpause Kubernetes",
+ "",
"```",
"minikube unpause [flags]",
... // 30 identical lines
}, "\n")
3de4046 to
15c8fa9
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, prezha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes: #2117
add support for namespace:
--namespaceflag forstartcommandexample
~/.kube/config:
❯ minikube start --namespace='production'
~/.minikube/profiles/minikube/config.json:
~/.kube/config: