8000 simplify addon code by fixing gcp-auth failure policy by sharifelgamal · Pull Request #9408 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

simplify addon code by fixing gcp-auth failure policy - #9408

Merged
medyagh merged 3 commits into
kubernetes:masterfrom
sharifelgamal:failure-policy
Oct 12, 2020
Merged

medyagh merged 3 commits into
kubernetes:masterfrom
sharifelgamal:failure-policy

Conversation

@sharifelgamal
Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 6, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@codecov-io
codecov-io commented Oct 6, 2020 •
Copy link
Copy Markdown

Codecov Report

Merging #9408 into master will decrease coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9408      +/-   ##
==========================================
- Coverage   29.21%   28.79%   -0.42%     
==========================================
  Files         171      172       +1     
  Lines       10444    10599     +155     
==========================================
+ Hits         3051     3052       +1     
- Misses       6969     7124     +155     
+ Partials      424      423       -1     
Impacted Files Coverage Δ
pkg/addons/addons.go 35.26% <ø> (+1.00%) ⬆️
cmd/minikube/cmd/start.go 9.38% <0.00%> (-0.08%) ⬇️
cmd/minikube/cmd/stop.go 4.00% <0.00%> (ø)
pkg/drivers/kic/oci/errors.go 0.00% <0.00%> (ø)
pkg/minikube/translate/translations.go 0.00% <0.00%> (ø)
cmd/minikube/cmd/start_flags.go 47.16% <0.00%> (+0.03%) ⬆️

@sharifelgamal
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 7, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9408): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9408/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9408/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9408): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9408/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9408/minikube: exec format error

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2020
@TravisBuddy
Copy link
Copy Markdown

Travis tests have failed

Hey @sharifelgamal,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.14.0-beta.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.13.1 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="d13834e3582c2336bc636601746a467c0ad49ae7" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.30.0'
golangci/golangci-lint info found version: 1.30.0 for v1.30.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
WARN [runner] Can't run linter goanalysis_metalinter: S1010: failed prerequisites: [(inspect@k8s.io/minikube/test/integration [k8s.io/minikube/test/integration.test], isgenerated@k8s.io/minikube/test/integration [k8s.io/minikube/test/integration.test]): analysis skipped: errors in package: [/home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/addons_test.go:589:10: no new variables on left side of :=]] 
WARN [runner] Can't run linter unused: buildir: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/addons_test.go:589:10: no new variables on left side of :=] 
ERRO Running error: buildir: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/addons_test.go:589:10: no new variables on left side of :=] 
Makefile:435: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 3
= go mod ================================================================
ok
= boilerplate ===========================================================
ok
Makefile:316: recipe for target 'test' failed
make: *** [test] Error 4
TravisBuddy Request Identifier: 5ea5f380-09a5-11eb-b9d6-41d4da7e5060

@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
Times for minikube: 62.5s 60.7s 59.1s
Average time for minikube: 60.7s

Times for Minikube (PR 9408): 55.4s 61.0s 60.7s
Average time for Minikube (PR 9408): 59.0s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9408) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0-beta.0 on   | 0.1s     | 0.0s               |
| Debian 9.11                    |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 35.5s    | 33.0s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.4s    | 23.8s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.5s     | 1.8s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.3s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.1s     | 0.5s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 27.6s 27.4s 27.7s
Average time for minikube: 27.6s

Times for Minikube (PR 9408): 27.1s 26.1s 28.6s
Average time for Minikube (PR 9408): 27.3s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9408) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0-beta.0 on   | 0.2s     | 0.2s               |
| Debian 9.11                    |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.0s     | 8.7s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 17.2s    | 17.2s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 0.9s     | 0.9s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.2s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

@medyagh
medyagh merged commit 88304ef into kubernetes:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0