8000 Fix ForwardedPort for podman version 2.0.1 and up by afbjorklund · Pull Request #9237 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Fix ForwardedPort for podman version 2.0.1 and up - #9237

Merged
medyagh merged 2 commits into
kubernetes:masterfrom
afbjorklund:podman2-port
Sep 15, 2020
Merged

medyagh merged 2 commits into
kubernetes:masterfrom
afbjorklund:podman2-port

Conversation

@afbjorklund
Copy link
Copy Markdown
Collaborator

Increasing Docker compatibility broke old Podman v1 code

Change to use the Docker parsing code for Podman >= 2.0.1

Closes #9120

Increasing Docker compatibility broke Podman v1
@afbjorklund
afbjorklund requested a review from medyagh September 13, 2020 20:20
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 13, 2020
For podman, "overlay" and "overlay2" are the same
@afbjorklund
Copy link
Copy Markdown
Collaborator Author

Also removed stupid warning from Docker.

❗ podman is currently using the overlay storage driver, consider switching to overlay2 for better performance

When using Podman, they are the same...

https://github.com/containers/storage/blob/master/drivers/overlay/overlay.go#L121_L122

@medyagh
medyagh merged commit 48a32a0 into kubernetes:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Podman v2 breaks the podman driver

4 participants

0