Repository navigation
docker: Improve overlay module check (behavior & UX) - #9163
Conversation
… modules, like WSL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
kvm2 Driver |
There was a problem hiding this comment.
this PR is removing the Second way of verifying if the first way is failing, which is bad
because on some distros (that I tried) the first way fails but the second way works
path := fmt.Sprintf("/lib/modules/%s/modules.builtin", string(out))
|
It is not removing the second way - it's replacing both with something that will work on all kernels: those with either built-in modules (second check) or pluggable modules (first check)
…On Wed, Sep 2, 2020 at 12:30 PM Medya Ghazizadeh ***@***.***> wrote:
***@***.**** requested changes on this pull request.
this PR is removing the Second way of verifying if the first way is
failing, which is bad
because on some distros (that I tried) the first way fails but the second
way works
path := fmt.Sprintf("/lib/modules/%s/modules.builtin", string(out))
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9163 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAYYMHKFD36HGGCIFP2YI3SD2ML7ANCNFSM4QTOQPTA>
.
|
Some improvements to the driver performance UX, based on testing in WSL2:
Old UX
New UX
💨 For improved Docker performance, enable the overlay Linux kernel module using 'modprobe overlay'