8000 Fix "cache add" for local images by cherry-picking go-containerregistry fix by afbjorklund · Pull Request #9160 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Fix "cache add" for local images by cherry-picking go-containerregistry fix - #9160

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
afbjorklund:go-containerregistry-docker
Sep 2, 2020
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
afbjorklund:go-containerregistry-docker

Conversation

@afbjorklund
@afbjorklund afbjorklund commented Sep 2, 2020 •
Copy link
Copy Markdown
Collaborator

google/go-containerregistry@72edbad

Updated to v0.1.0, but go mod didn't want to accept it

Closes #8867

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 2, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 2, 2020
@tstromberg
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 2, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
Times for minikube: 84.3s 89.1s 84.6s
Average time for minikube: 86.0s

Times for Minikube (PR 9160): 87.8s 86.0s 88.8s
Average time for Minikube (PR 9160): 87.5s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9160) |
+--------------------------------+----------+--------------------+
| * minikube v1.12.3 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.9s    | 40.5s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.0 | 43.7s    | 44.9s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.7s     | 1.7s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.5s     | 0.2s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
| * Done! kubectl is now         | 0.1s     | 0.1s               |
| configured to use "minikube"   |          |                    |
|                                | 0.0s     | 0.0s               |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 45.2s 44.3s 52.6s
Average time for minikube: 47.3s

Times for Minikube (PR 9160): 45.1s 42.2s 42.7s
Average time for Minikube (PR 9160): 43.3s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9160) |
+--------------------------------+----------+--------------------+
| * minikube v1.12.3 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.0s     | 0.0s               |
| based on user configuration    |          |                    |
|                                | 1.0s     | 0.0s               |
|                                |          |                    |
| * Starting control plane node  |          |                    |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    |          |                    |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.0 |          |                    |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         |          |                    |
| components...                  |          |                    |
| * Enabled addons:              |          |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
|                                |          |                    |
+--------------------------------+----------+--------------------+

@tstromberg
tstromberg merged commit b1fc326 into kubernetes:master Sep 2, 2020
@tstromberg
Copy link
Copy Markdown
Contributor

I can confirm that this fixes local cache add.

@tstromberg tstromberg changed the title Cherry-pick docker api fix to go-containerregistry Fix "cache add" for local images by cherry-picking go-containerregistry fix Sep 2, 2020
@medyagh medyagh mentioned this pull request Sep 9, 2020
1 of 11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minikube cache add looking for remote images not local?

4 participants

0