8000 Increase preload version to v6 by priyawadhwa · Pull Request #9159 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Increase preload version to v6 - #9159

#9159
Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
priyawadhwa:upgrade-preload
Sep 2, 2020
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
priyawadhwa:upgrade-preload

Conversation

@priyawadhwa
@priyawadhwa priyawadhwa commented Sep 2, 2020 •
Copy link
Copy Markdown

We upgraded the dashboard image in #9129, this will rebuild tarballs to include the latest version.

This should also fix a small performance regression, where start time was increased by 25% on kvm2, probably because preload failed and we were waiting for the new dashboard image to download. PR bot comment

We upgraded the dashboard image in kubernetes#9129, this will rebuild tarballs to include the latest version.

This should also fix a small performance regression, where start time was increased by 25% on kvm2, probably becaues we were waiting for the new dashboard image to download. [PR bot comment](kubernetes#9129 (comment))
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@afbjorklund
afbjorklund commented Sep 2, 2020 •
Copy link
Copy Markdown
Collaborator

I think that once one image is missing from the preload, it gives up on all the other ones too.

Actually it only does a retrieve, which re-downloads the manifest - but the layers are still there

@priyawadhwa
Copy link
Copy Markdown
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 2, 2020
@tstromberg
Copy link
Copy Markdown
Contributor

@priyawadhwa - can you approve #9151 first?

@kubernetes kubernetes deleted a comment from minikube-pr-bot Sep 2, 2020
@tstromberg
tstromberg merged commit 78deeb5 into kubernetes:master Sep 2, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
Times for minikube: 86.5s 105.4s 95.0s
Average time for minikube: 95.7s

Times for Minikube (PR 9159): 114.2s 104.3s 100.5s
Average time for Minikube (PR 9159): 106.3s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9159) |
+--------------------------------+----------+--------------------+
| * minikube v1.12.3 on Debian   | 0.2s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 43.7s    | 20.3s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.0 | 49.3s    | 82.3s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.7s     | 1.9s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.5s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
| * Done! kubectl is now         | 0.2s     | 1.5s               |
| configured to use "minikube"   |          |                    |
|                                | 0.0s     | 0.0s               |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 65.1s 55.4s 53.2s
Average time for minikube: 57.9s

Times for Minikube (PR 9159): 59.1s 58.3s 59.5s
Average time for Minikube (PR 9159): 59.0s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9159) |
+--------------------------------+----------+--------------------+
| * minikube v1.12.3 on Debian   | 0.3s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.0s     | 0.0s               |
| based on user configuration    |          |                    |
|                                | 0.0s     | 0.0s               |
|                                |          |                    |
| * Starting control plane node  |          |                    |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    |          |                    |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.0 |          |                    |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         |          |                    |
| components...                  |          |                    |
| * Enabled addons:              |          |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
|                                |          |                    |
+--------------------------------+----------+--------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0