8000 start: fixed the type value for kubectl version mismatch to warning by vinu2003 · Pull Request #9157 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

start: fixed the type value for kubectl version mismatch to warning - #9157

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
vinu2003:fix-jsontypevalue-kubectlversionmismatch-startcmd
Sep 2, 2020
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
vinu2003:fix-jsontypevalue-kubectlversionmismatch-startcmd

Conversation

@vinu2003
@vinu2003 vinu2003 commented Sep 2, 2020 •
Copy link
Copy Markdown
Contributor

This PR addresses code changes that fix the value for type from "type":"io.k8s.sigs.minikube.error" to "type":"io.k8s.sigs.minikube.warning" for the kubectl version mismatch.

Before:

{"data":{"message":"/home/vinu/go_workspace/bin/kubectl is version 1.20.0-alpha.0.188+65a1f24b205ece-dirty, which may be incompatible with Kubernetes 1.19.0."},"datacontenttype":"application/json","id":"aa1a2e48-2cd6-4c31-818e-d408cd16894e","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.warning"}
{"data":{"message":"You can also use 'minikube kubectl -- get pods' to invoke a matching version"},"datacontenttype":"application/json","id":"9ee30007-ce04-4140-ad2f-7c0b65e4dab3","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.error"}

After:

{"data":{"message":"/home/vinu/go_workspace/bin/kubectl is version 1.20.0-alpha.0.188+65a1f24b205ece-dirty, which may be incompatible with Kubernetes 1.19.0."},"datacontenttype":"application/json","id":"fa37ebd3-f512-49e3-91b7-b68d7752847e","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.warning"}
{"data":{"message":"You can also use 'minikube kubectl -- get pods' to invoke a matching version"},"datacontenttype":"application/json","id":"a1ce4f17-7980-4cdd-84b7-00de4993110c","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.warning"}

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @vinu2003. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vinu2003
To complete the pull request process, please assign josedonizetti
You can assign the PR to them by writing /assign @josedonizetti in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 2, 2020
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@vinu2003
vinu2003 commented Sep 2, 2020
Copy link
Copy Markdown
Contributor Author

/cc @tstromberg

@tstromberg
Copy link
Copy Markdown
Contributor

Thank you!

@tstromberg
tstromberg merged commit 47af03b into kubernetes:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0