Repository navigation
Fix --extra-config for scheduler/controllerManager by removing hardcoded values - #9136
Conversation
This sets leader-elect=false as extra options for the scheduler and controller manager. This way, users can easily override those values. This will also allow users to specify additional flags via `--extra-config` without overwriting the leader-elect section in the config.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
kvm2 Driver Times for Minikube (PR 9136): 62.0s 65.8s 64.6s Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 9136): 30.4s 29.6s 28.7s Averages Time Per Log Details |
|
Thank you! |
Now, users can specify additional flags to scheduler/controllerManager without overriding the place in the config where we set leader-elect=false
Verified that this works locally
Closes #9134