8000 Add MINIKUBE_IN_STYLE auto-detection for Windows terminal by tstromberg · Pull Request #9127 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add MINIKUBE_IN_STYLE auto-detection for Windows terminal - #9127

Merged
tstromberg merged 2 commits into
masterfrom
windows-emoji
Aug 31, 2020
Merged

tstromberg merged 2 commits into
masterfrom
windows-emoji

Conversation

@tstromberg
Copy link
Copy Markdown
Contributor

Confirmed that color/emoji works fine with the current Windows Terminal build on Windows 10 Pro 10.0.19042. This will not impact most powershell/cmd.exe users for some time, as they do not yet use the latest Windows Terminal. Auto-detection inspired by:

https://stackoverflow.com/questions/59733731/how-do-detect-if-running-in-the-new-windows-terminal

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 31, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2020
@tstromberg
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 31, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9127): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9127/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9127/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9127): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9127/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9127/minikube: exec format error

@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
Times for minikube: 65.7s 61.8s 66.3s
Average time for minikube: 64.6s

Times for Minikube (PR 9127): 63.7s 66.1s 63.6s
Average time for Minikube (PR 9127): 64.5s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9127) |
+--------------------------------+----------+--------------------+
| * minikube v1.12.3 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.3s    | 41.2s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.18.3 | 22.4s    | 20.7s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.4s     | 1.4s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.3s     | 1.0s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
| * Done! kubectl is now         | 0.1s     | 0.1s               |
| configured to use "minikube"   |          |                    |
|                                | 0.0s     | 0.0s               |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 28.8s 26.5s 26.0s
Average time for minikube: 27.1s

Times for Minikube (PR 9127): 27.5s 28.1s 26.4s
Average time for Minikube (PR 9127): 27.3s

Averages Time Per Log

Details
+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9127) |
+--------------------------------+----------+--------------------+
| * minikube v1.12.3 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.8s     | 8.6s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.18.3 | 17.1s    | 17.5s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 0.9s     | 0.9s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.0s     | 0.0s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
| * Done! kubectl is now         | 0.1s     | 0.1s               |
| configured to use "minikube"   |          |                    |
|                                | 0.0s     | 0.0s               |
+--------------------------------+----------+--------------------+

@tstromberg
tstromberg merged commit df906e5 into master Aug 31, 2020
@medyagh
medyagh deleted the windows-emoji branch January 27, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0