Repository navigation
start: fixed the type value for latest minikube version availability message - #9109
Conversation
|
Hi @vinu2003. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vinu2003 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Travis tests have failedHey @vinu2003, 1st Buildmake testTravisBuddy Request Identifier: f446f260-e905-11ea-ae3c-2d16223a9f65 |
|
Can one of the admins verify this patch? |
|
need to fix the unit tests |
5306231 to
3e79f85
Compare
There was a problem hiding this comment.
This seems reasonable, now that we only call this from start.go. Thanks!
This PR addresses code changes that fix the value for type from
"type":"io.k8s.sigs.minikube.error"to"type":"io.k8s.sigs.minikube.step"for the latest minikube version availability message.Fixes #9108