8000 print download progress every second by priyawadhwa · Pull Request #9099 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

print download progress every second - #9099

Merged
priyawadhwa merged 2 commits into
kubernetes:masterfrom
priyawadhwa:limit-json
Aug 28, 2020
Merged

priyawadhwa merged 2 commits into
kubernetes:masterfrom
priyawadhwa:limit-json

Conversation

@priyawadhwa
@priyawadhwa priyawadhwa commented Aug 26, 2020 •
Copy link
Copy Markdown

previously we were printing 6000x/sec which is unnecessary

fixes #9090

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2020
@priyawadhwa
Copy link
Copy Markdown
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 26, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9099): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9099/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9099/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9099): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9099/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9099/minikube: exec format error

@priyawadhwa
priyawadhwa merged commit bdd4fb6 into kubernetes:master Aug 28, 2020
@priyawadhwa
priyawadhwa deleted the limit-json branch August 28, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

limit json output updates for downloading files

4 participants

0